Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create playbook to update allsearch banner #5463

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Create playbook to update allsearch banner #5463

wants to merge 10 commits into from
+44 −0

Conversation

Beck-Davis
Copy link
Contributor

@Beck-Davis Beck-Davis commented Oct 23, 2024 •
edited
Loading

@Beck-Davis Beck-Davis changed the title started branch Create playbook to update allsearch banner Oct 23, 2024
@kayiwa kayiwa requested a review from maxkadel October 24, 2024 13:13
@maxkadel
Copy link
Contributor

  • It should run in /opt/allsearch_api/current, not /opt/allsearch_api/current/public
  • It occurs to me that this should only run against one machine in a given environment, since this updates the database and we don't want to do that via two machines
  • Maybe we can give defaults for alert_status ("info"), dismissible (true), and autoclear (false)
  • You may need to set the RAILS_ENV=staging or RAILS_ENV=production before running the rake task?

@Beck-Davis Beck-Davis marked this pull request as draft October 25, 2024 17:27
@kayiwa
Copy link
Member

kayiwa commented Oct 28, 2024

thanks @maxkadel given your comments. I'm wondering if this should live here instead. https://github.com/pulibrary/allsearch_api

Beck-Davis and others added 4 commits October 28, 2024 14:08
@Beck-Davis @kayiwa
started branch
a091b66
@VickieKarasic @acozine
@Beck-Davis @kayiwa
first pass at the banner rake task
f3e6403 
Co-authored-by: Alicia Cozine <acozine@users.noreply.github.com>
Co-authored-by: Beck Davis <beck-davis@users.noreply.github.com>
@VickieKarasic @acozine
@Beck-Davis @kayiwa
improving on rake task part of the playbook
25225bb 
Co-authored-by: Alicia Cozine <acozine@users.noreply.github.com>
Co-authored-by: Beck Davis <beck-davis@users.noreply.github.com>
@kayiwa
test path
c8a1688
kayiwa and others added 3 commits October 28, 2024 14:29
@kayiwa @Beck-Davis
change the exec environment
24caf48 
we change the remote user to deploy.
None of the tasks need elevated privileges so we make remote user to be
deploy

use bash to act as if it is a login shell
hard code the environment to staging
add default variables to pass

Co-authored-by: Beck Davis <beck-davis@users.noreply.github.com>
@kayiwa @Beck-Davis @VickieKarasic
spacing problems are spacing
2cc88b9 
we discovered that spacing matters for rake tasks

Co-authored-by: Beck Davis <beck-davis@users.noreply.github.com>
Co-authored-by: Vickie Karasic <vickiekarasic@users.noreply.github.com>
@kayiwa @Beck-Davis @VickieKarasic
add default path
2708367 
pass the path and environment variables

Co-authored-by: Beck Davis <beck-davis@users.noreply.github.com>
Co-authored-by: Vickie Karasic <vickiekarasic@users.noreply.github.com>
@Beck-Davis Beck-Davis marked this pull request as ready for review November 8, 2024 20:53
@acozine acozine marked this pull request as draft November 11, 2024 17:36
Beck-Davis and others added 3 commits November 13, 2024 15:30
@Beck-Davis
Add run_once
d650d77
@Beck-Davis @acozine
@kayiwa @maxkadel
Explore regex to address unescaped comma issue
2f15711 
Co-authored-by: Alicia Cozine <acozine@users.noreply.github.com>
Co-authored-by: Francis Kayiwa <kayiwa@users.noreply.github.com>
Co-authored-by: Max Kadel <maxkadel@users.noreply.github.com>
@Beck-Davis
Playbook is broken
4cb621e 
regex for unescaped commas on line 21 continues to thwart progress
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxkadel maxkadel Awaiting requested review from maxkadel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Beck-Davis @maxkadel @kayiwa @VickieKarasic