Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address #5548" #5549

Merged
merged 4 commits into from
Dec 2, 2024
Merged

Address #5548" #5549

merged 4 commits into from
Dec 2, 2024

Conversation

kevinreiss
Copy link
Member

No description provided.

acozine
acozine reviewed Nov 25, 2024
View reviewed changes
Copy link
Contributor

@acozine acozine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first commit added a package called php{{ php_version }}-gd but the second commit didn't incorporate it everywhere - is that because we don't need it? Or was that an oversight?

roles/php/molecule/default/verify.yml Outdated Show resolved Hide resolved
roles/php/tasks/main.yml Outdated Show resolved Hide resolved
roles/php/molecule/default/verify.yml Outdated Show resolved Hide resolved
@kayiwa kayiwa force-pushed the update_php8_3 branch 4 times, most recently from a82f7ee to 20dc75c Compare November 27, 2024 16:04
@acozine acozine marked this pull request as ready for review December 2, 2024 17:40
@acozine
Copy link
Contributor

acozine commented Dec 2, 2024

We ran this against staging and it fixed the can't-deploy problem outlined in #5548.

@acozine acozine merged commit 4975a77 into main Dec 2, 2024
72 checks passed
@acozine acozine deleted the update_php8_3 branch December 2, 2024 17:46
@acozine acozine mentioned this pull request Dec 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acozine acozine acozine left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevinreiss @acozine @kayiwa