Changed return links to hyperlinks (#1072)

* Changed return links to hyperlinks

* Fixed breaking tests

app/views/projects/approval_received.html.erb

@@ -7,6 +7,6 @@
 
     <p>If there are any issues in confirming the Active status of the project, you will receive a message at td-support@princeton.edu</p>
 
-  <%= button_to "Return to Dashboard", root_path, class: "btn btn-primary btn-sm", method: :get %>
+    <%= link_to "Return to Dashboard", root_path, class: "btn btn-primary btn-sm" %>
 
   </div>

app/views/projects/confirmation.html.erb

@@ -9,6 +9,6 @@
 
     If you have questions, please contact the team at <%= mail_to "tigerdata@princeton.edu" %>.</p>
 
-  <%= button_to "Return to Dashboard", root_path, class: "btn btn-primary btn-sm", method: :get %>
+    <%= link_to "Return to Dashboard", root_path, class: "btn btn-primary btn-sm" %>
 
   </div>

app/views/projects/revision_confirmation.html.erb

@@ -9,6 +9,6 @@
 
     If you have questions, please contact the team at <%= mail_to "tigerdata@princeton.edu" %>.</p>
 
-  <%= button_to "Return to Dashboard", root_path, class: "btn btn-primary btn-sm", method: :get %>
+    <%= link_to "Return to Dashboard", root_path, class: "btn btn-primary btn-sm" %>
 
   </div>

spec/system/project_spec.rb

@@ -138,7 +138,7 @@
         # This is the confirmation page. It needs a button to return to the dashboard
         # and it needs to be_axe_clean.
         expect(page).to have_content "Project Revision Request Received"
-        expect(page).to have_button "Return to Dashboard"
+        expect(page).to have_link "Return to Dashboard"
         expect(page).to be_axe_clean
           .according_to(:wcag2a, :wcag2aa, :wcag21a, :wcag21aa, :section508)
           .skipping(:'color-contrast')
@@ -196,7 +196,7 @@
       # This is the confirmation page. It needs a button to return to the dashboard
       # and it needs to be_axe_clean.
       expect(page).to have_content "New Project Request Received"
-      expect(page).to have_button "Return to Dashboard"
+      expect(page).to have_link "Return to Dashboard"
       expect(page).to be_axe_clean
         .according_to(:wcag2a, :wcag2aa, :wcag21a, :wcag21aa, :section508)
         .skipping(:'color-contrast')
@@ -450,7 +450,7 @@
       # This is the confirmation page. It needs a button to return to the dashboard
       # and it needs to be_axe_clean.
       expect(page).to have_content "Project Approval Received"
-      expect(page).to have_button "Return to Dashboard"
+      expect(page).to have_link "Return to Dashboard"
 
       expect(page).to be_axe_clean
         .according_to(:wcag2a, :wcag2aa, :wcag21a, :wcag21aa, :section508)