Add option to enable internal pipelining to xbar.
#268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
thommythomaso
force-pushed
the
xbar_pipeline-tbenz
branch
5 times, most recently
from
185d4f4 to
42473bf
Compare
micprog
reviewed
Sep 30, 2022
test/tb_axi_xbar.sv
Outdated
Comment on lines
282
to
297
| axi_xbar #( | ||
| .Cfg ( xbar_cfg ), | ||
| .slv_aw_chan_t( aw_chan_mst_t ), | ||
| .mst_aw_chan_t( aw_chan_slv_t ), | ||
| .w_chan_t ( w_chan_t ), | ||
| .slv_b_chan_t ( b_chan_mst_t ), | ||
| .mst_b_chan_t ( b_chan_slv_t ), | ||
| .slv_ar_chan_t( ar_chan_mst_t ), | ||
| .mst_ar_chan_t( ar_chan_slv_t ), | ||
| .slv_r_chan_t ( r_chan_mst_t ), | ||
| .mst_r_chan_t ( r_chan_slv_t ), | ||
| .slv_req_t ( mst_req_t ), | ||
| .slv_resp_t ( mst_resp_t ), | ||
| .mst_req_t ( slv_req_t ), | ||
| .mst_resp_t ( slv_resp_t ), | ||
| .rule_t ( rule_t ) |
There was a problem hiding this comment.
I'd argue we stick to testing the axi_xbar_intf, as anything that tests it will also test the axi_xbar.
There was a problem hiding this comment.
Will change back
Comment on lines
+53
to
63
| /// Address rule type for the address decoders from `common_cells:addr_decode`. | ||
| /// Example types are provided in `axi_pkg`. | ||
| /// Required struct fields: | ||
| /// ``` | ||
| /// typedef struct packed { | ||
| /// int unsigned idx; | ||
| /// axi_addr_t start_addr; | ||
| /// axi_addr_t end_addr; | ||
| /// } rule_t; | ||
| /// ``` | ||
| parameter type rule_t = axi_pkg::xbar_rule_64_t |
There was a problem hiding this comment.
We discussed removing this in a future update, correct? I don't remember if it was planned for this update or the next.
There was a problem hiding this comment.
The parameter struct should be removed soon. But that will be the last two PRs of Wolfgang.
thommythomaso
force-pushed
the
xbar_pipeline-tbenz
branch
from
42473bf to
66e5200
Compare
micprog
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #116.