It looks like option order can matter in unintuitive ways.

[quba42]

Summary

While using Pulp CLI, I encountered the following:

$ oci-env pulp deb repository version destroy --version 1 --repository=${ENTITIES_NAME}
Error: A apt repository must be specified for this command.
$ oci-env pulp deb repository version destroy --repository=${ENTITIES_NAME} --version 1
Started background task /pulp/api/v3/tasks/51676f37-ea1f-4c97-b0e8-031f93577892/
.Done.

Steps to reproduce

1. Create some repository, with some content in it.
2. Delete a repository version using the --version and --repository flags in that order
3. You get e.g.: Error: A apt repository must be specified for this command.

Expected behavior

The order the --version and --repository flags are given to a CLI command in should not matter.

Pulp and pulp-cli version info

# pulp --version
pulp3 command line interface, version 0.16.0

  "versions": [
    {
      "component": "core",
      "version": "3.22.0.dev",
      "package": "pulpcore"
    },
    {
      "component": "deb",
      "version": "2.21.0.dev",
      "package": "pulp_deb"
    },
    {
      "component": "file",
      "version": "1.12.0.dev",
      "package": "pulp-file"
    }
  ],

Additonal context

I suspect this is nothing to do with pulp-cli-deb and will happen equally for other content plugins, but I did not test this.

[ggainey]

My hunch is that click-processing hits https://github.com/pulp/pulp-cli/blob/main/pulpcore/cli/common/generic.py#L356 before it's had a chance to add a RepositoryContext to the context, and we're asserting on "no repo found". To address this we prob want to do something like --version=name:version , --repository= implies latest_version, and you can't specify both.

At a minimum, we need to document that "order matters" in this case.

[MichalPysik]

I have tested the issue on a pulp file repository and can confirm that this is indeed not pulp-deb specific.

[gerrod3]

This is the default behavior of click it seems: https://click.palletsprojects.com/en/8.1.x/advanced/#callback-evaluation-order. Going to need to be more clever in our callbacks if we want to be order invariant.