Adding pulp-2to3-migration support #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddavis
force-pushed
the
migration-support
branch
2 times, most recently
from
09d51a0 to
31f302f
Compare
daviddavis
force-pushed
the
migration-support
branch
2 times, most recently
from
10224a7 to
dfe52ae
Compare
mdellweg
reviewed
Feb 15, 2021
mdellweg
reviewed
Feb 15, 2021
mdellweg
reviewed
Feb 15, 2021
| # shellcheck source=tests/scripts/config.source | ||
| . "$(dirname "$(dirname "$(realpath "$0")")")"/config.source | ||
|
|
||
| pulp debug has-plugin --name "pulp_2to3_migration" || exit 3 |
There was a problem hiding this comment.
Am i right, that these tests will not run in our container based CI?
Would this be reason to have this plugin packaged independently?
There was a problem hiding this comment.
Am i right, that these tests will not run in our container based CI?
That's correct
Would this be reason to have this plugin packaged independently?
That's a good question. Let's discuss at our CLI meeting?
daviddavis
force-pushed
the
migration-support
branch
from
dfe52ae to
3cbc0a9
Compare
daviddavis
force-pushed
the
migration-support
branch
from
3cbc0a9 to
b060e36
Compare
daviddavis
pushed a commit
to daviddavis/pulp-2to3-migration
that referenced
this pull request
Feb 17, 2021
Required PR: pulp/pulp-cli#142 [noissue]
daviddavis
pushed a commit
to daviddavis/pulp-2to3-migration
that referenced
this pull request
Feb 17, 2021
Required PR: pulp/pulp-cli#142 [noissue]
daviddavis
pushed a commit
to daviddavis/pulp-2to3-migration
that referenced
this pull request
Feb 17, 2021
Required PR: pulp/pulp-cli#142 [noissue]
daviddavis
pushed a commit
to daviddavis/pulp-2to3-migration
that referenced
this pull request
Feb 17, 2021
Required PR: pulp/pulp-cli#142 [noissue]
|
Looks like the tests are running successfully against the migration plugin: pulp/pulp-2to3-migration#315 |
mdellweg
approved these changes
Feb 18, 2021
goosemania
pushed a commit
to pulp/pulp-2to3-migration
that referenced
this pull request
Feb 22, 2021
Required PR: pulp/pulp-cli#142 [noissue]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #133