Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation to file content json parameters #308

Merged
merged 1 commit into from
Jul 19, 2021
Merged

Add validation to file content json parameters #308

merged 1 commit into from
Jul 19, 2021

Conversation

mdellweg
Copy link
Member

fixes #255

daviddavis
daviddavis approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@daviddavis daviddavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe add a test?

@mdellweg mdellweg added this to the 0.11.0 milestone Jul 16, 2021
@mdellweg
Copy link
Member Author

LGTM. Maybe add a test?

That's a bit hard, as it does not change the condition for failure.

@daviddavis
Copy link
Contributor

Can you check that a certain error message gets emitted when you pass in invalid json?

@mdellweg mdellweg merged commit c69f466 into pulp:develop Jul 19, 2021
@mdellweg mdellweg deleted the input_validation branch July 19, 2021 16:45
mdellweg added a commit to mdellweg/pulp-cli that referenced this pull request Sep 30, 2021
@mdellweg
Bump pulpcore version requirement to >= 3.11
233f80b 
Require pulpcore>=3.11 and drop all workarounds for older versions.
Transitive plugin requirements:
  pulp_container>=2.3

fixes pulp#308
@mdellweg mdellweg mentioned this pull request Sep 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggainey ggainey ggainey approved these changes

@daviddavis daviddavis daviddavis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.

Exception raised when supplying invalid json format
3 participants
@mdellweg @daviddavis @ggainey