Add global distribution commands #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerrod3
force-pushed
the
global-distro
branch
2 times, most recently
from
9dbc170 to
dcba05d
Compare
mdellweg
reviewed
Jul 15, 2022
| @@ -227,6 +227,13 @@ class PulpContentRedirectContentGuardContext(PulpEntityContext): | |||
| ID_PREFIX = "contentguards_core_content_redirect" | |||
|
|
|||
|
|
|||
| class PulpDistributionContext(PulpEntityContext): | |||
There was a problem hiding this comment.
Should we have all the Distributions inherit from this? (I know there is little value in this unless we have some fancy extra methods or NULLABLES here.)
There was a problem hiding this comment.
I would say we leave it as is now and in the future we find extra bits that need to be shared we move it to common and have others inherit.
mdellweg
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #517
Please be sure you have read our documentation on code contributions:
https://docs.pulpproject.org/pulp_cli/contributing/#code-conventions