Added --optimize and --sync-policy options to rpm repo sync. #540
Conversation
ggainey
force-pushed
the
462_opt_syncpolicy
branch
from
05b53c5 to
99ee12d
Compare
| "--mirror/--no-mirror", | ||
| default=None, | ||
| help=""" | ||
| DEPRECATED: If True, sync_policy will default to 'mirror_complete' instead |
There was a problem hiding this comment.
I don't know. Is "deprecated" the proper term for the cli? Should we explain, that this is only for certain old versions of the plugin? How about needs_plugin with an upper bound?
There was a problem hiding this comment.
It's deprecated with the same wording in the pulp_rpm REST API : https://github.com/pulp/pulp_rpm/blob/main/pulp_rpm/app/serializers/repository.py#L298
It's been deprecated since pulp_rpm/3.16.0. I don't want to put a max=3.16 for RPM on it, because people are using it now, and would suddenly break. We could put a max=3.17 on it, which would make it stop working when pulp_rpm/3.18 is released Really Soon Now (and I don't know if pulp_rpm is going to be able to actually remove the option any time soon)
There was a problem hiding this comment.
OK, as long as the option is there, we should support it. 👍
ggainey
force-pushed
the
462_opt_syncpolicy
branch
from
99ee12d to
c7a58ce
Compare
fixes pulp#462. Co-authored by: Grant Gainey <ggainey@redhat.com>
ggainey
force-pushed
the
462_opt_syncpolicy
branch
from
c7a58ce to
f6d294b
Compare
fixes #462.
Co-authored by: Grant Gainey ggainey@redhat.com