Add the --wait option to the task-group show command #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubosmj
force-pushed
the
add-wait-to-group-tasks-459
branch
6 times, most recently
from
11842ea to
6049764
Compare
mdellweg
requested changes
Oct 12, 2022
| "task_group_read", parameters={"task_group_href": task_group["pulp_href"]} | ||
| "task_groups_read", parameters={"task_group_href": task_group["pulp_href"]} |
There was a problem hiding this comment.
This looks like a bugfix. Didn't we have tests for it?
There was a problem hiding this comment.
Yes, it is a bug fix. I think we do not have any tests for it. The method wait_for_task_group was not invoked anywhere.
CHANGES/459.feature
Outdated
| @@ -0,0 +1,2 @@ | |||
| Introduced the option ``--wait`` for the task-group show command. By using this option, details | |||
| of a specific task-group will be shown only in case all related tasks will be finished. | |||
There was a problem hiding this comment.
Suggested change
| of a specific task-group will be shown only in case all related tasks will be finished. | |
| of the task-group will be shown only after waiting for all related tasks to finish. |
Please don't do the crazy wrapping here. Wrap whole sentences instead.
tests/scripts/pulp_file/test_acs.sh
Outdated
| @@ -37,7 +37,12 @@ test "$(echo "$OUTPUT" | jq ".paths | length")" -eq 2 | |||
| # test refresh | |||
| expect_succ pulp file acs refresh --name $acs | |||
There was a problem hiding this comment.
Will "ERROUTPUT" be still accessible on the next line?
There was a problem hiding this comment.
It will only be overwritten on the next "expect_*"
There was a problem hiding this comment.
Or you mean that "--background" still tells you about the triggered taskgroup? I hope so.
pulpcore/cli/core/task_group.py
Outdated
| @@ -18,3 +28,49 @@ def task_group(ctx: click.Context, pulp_ctx: PulpContext) -> None: | |||
|
|
|||
| task_group.add_command(list_command()) | |||
| task_group.add_command(show_command(decorators=[href_option])) | |||
lubosmj
force-pushed
the
add-wait-to-group-tasks-459
branch
from
6049764 to
c3d81fb
Compare
lubosmj
force-pushed
the
add-wait-to-group-tasks-459
branch
from
c3d81fb to
6070b47
Compare
mdellweg
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #459