Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git_url (and others) are bad fields on collection content #1721

Open
mdellweg opened this issue Jan 10, 2024 · 3 comments
Open

git_url (and others) are bad fields on collection content #1721

mdellweg opened this issue Jan 10, 2024 · 3 comments

Comments

@mdellweg
Copy link
Member

          I think this assertion fails due to the parallel nature of the test. In other parallel sync tests we sync the amazon.aws collection which means the git sync will use that version already present in the system (name,namespace uniqeuness strikes again) causing the metadata to differ.

Originally posted by @gerrod3 in #1711 (comment)

@mdellweg
Copy link
Member Author

We need to remove them.
In general, as long as we allow content to be shared, the content itself cannot tell you where it came from.

@newswangerd
Copy link
Contributor

as long as we're not removing any fields that come from metadata/manifest, this should be fine.

We definitely need to keep fields such as metadata["repository'].

@mdellweg
Copy link
Member Author

as long as we're not removing any fields that come from metadata/manifest, this should be fine.

We definitely need to keep fields such as metadata["repository'].

That metadata is part of the actual collection artifact, right? Then there's no issue with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants