Rewrite and cleanup some tests #1711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdellweg
force-pushed
the
modern_tests
branch
from
db59fe9 to
b926d9d
Compare
mdellweg
force-pushed
the
modern_tests
branch
4 times, most recently
from
6616e77 to
5fecd96
Compare
[noissue]
mdellweg
force-pushed
the
modern_tests
branch
from
5fecd96 to
eff7634
Compare
gerrod3
approved these changes
Jan 10, 2024
Comment on lines
+106
to
+107
| # These assertions are failing way too often. | ||
| # assert version.git_url == "https://github.com/ansible-collections/amazon.aws/" |
There was a problem hiding this comment.
I think this assertion fails due to the parallel nature of the test. In other parallel sync tests we sync the amazon.aws collection which means the git sync will use that version already present in the system (name,namespace uniqeuness strikes again) causing the metadata to differ.
There was a problem hiding this comment.
I do believe so. The problem is, that means the feature is in conflict with shareable content.
Comment on lines
+291
to
+293
| tmpdir = tmp_path_factory.mktemp("collection") | ||
| collection = build_collection("skeleton", **kwargs) | ||
| collection.filename = shutil.copy(collection.filename, tmpdir) |
There was a problem hiding this comment.
Nice use of the tmp_path_factory to get this fixture parallelize.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[noissue]