Fix sync failure on unreachable namespace avatar #1544
Conversation
gerrod3
force-pushed
the
logo-404
branch
2 times, most recently
from
6f01a8d to
1067efb
Compare
| except ClientError as e: | ||
| # Reset DA so that future stages can properly handle it | ||
| self.artifact = artifact_copy | ||
| self.deferred_download = True |
There was a problem hiding this comment.
It reminds me a lot of https://github.com/pulp/pulp_deb/blob/main/pulp_deb/app/tasks/synchronizing.py#L192 with https://github.com/pulp/pulp_deb/blob/main/pulp_deb/app/tasks/synchronizing.py#L513 .
Can you elaborate more on the strategy? Do we handle the namespace as if no avatar existed, or do we turn the artifact into on-demand?
There was a problem hiding this comment.
It is very similar. The current strategy I am using is to handle the namespace as if no avatar existed. In the custom content saver stage I modify the namespace's metadata before save if the avatar failed to download.
There was a problem hiding this comment.
Would it help to elevate the FailsafeDeclarativeArtifact to pulpcore?
There was a problem hiding this comment.
Probably, we could design it to accept a list of exceptions during download that would be failsafe.
Backport to 0.17: 💚 backport PR created✅ Backport PR branch: Backported as #1551 🤖 @patchback |
|
AAP-14090 |
fixes: #1543