Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot sync library/busybox because of unsupported mediatype "manifest.v1+prettyjws" #1444

Closed
lubosmj opened this issue Dec 13, 2023 · 6 comments · Fixed by #1445
Closed

Cannot sync library/busybox because of unsupported mediatype "manifest.v1+prettyjws" #1444

lubosmj opened this issue Dec 13, 2023 · 6 comments · Fixed by #1445
Assignees
@lubosmj
Labels
Issue Satellite

Comments

@lubosmj
Copy link
Member

lubosmj commented Dec 13, 2023 •
edited
Loading

Version
2.15+

Describe the bug
Users cannot sync the gcr.io/library/busybox repository.

To Reproduce

pulp container remote create --name test --upstream-name library/busybox --url https://mirror.gcr.io
pulp container repository create --name test
pulp container repository sync --name test --remote test

Expected behavior
Sync task finishes. This works in 2.14 and below.

Additional context

http https://mirror.gcr.io/v2/library/busybox/manifests/1.24 'Accept: application/vnd.docker.distribution.manifest.v2+json,application/vnd.docker.distribution.manifest.v1+json,application/vnd.docker.distribution.manifest.list.v2+json,application/vnd.oci.image.index.v1+json,application/vnd.oci.image.manifest.v1+json'

HTTP/1.1 404 Not Found
Alt-Svc: h3=":443"; ma=2592000,h3-29=":443"; ma=2592000
Content-Length: 411
Content-Type: application/json; charset=utf-8
Date: Wed, 13 Dec 2023 18:31:08 GMT
Docker-Distribution-Api-Version: registry/2.0
X-Content-Type-Options: nosniff
X-Frame-Options: SAMEORIGIN
X-Xss-Protection: 0

{
    "errors": [
        {
            "code": "MANIFEST_UNKNOWN",
            "message": "Manifest has media type \"application/vnd.docker.distribution.manifest.v1+prettyjws\" but client accepts [\"application/vnd.docker.distribution.manifest.v2+json,application/vnd.docker.distribution.manifest.v1+json,application/vnd.docker.distribution.manifest.list.v2+json,application/vnd.oci.image.index.v1+json,application/vnd.oci.image.manifest.v1+json\"]"
        }
    ]
}
@ipanova
Copy link
Member

ipanova commented Dec 13, 2023

i'm afraid this should be reproducible also on 2.14 branch because this fix that introduced the issue got backported through 2.14 #1304

@ipanova
Copy link
Member

ipanova commented Dec 13, 2023

strange however why katello says it works on python39-pulp-container-2.14.7-1.el8pc.noarch.rpm?

@lubosmj
Copy link
Member Author

lubosmj commented Dec 13, 2023

The solution is to add the missing application/vnd.docker.distribution.manifest.v1+prettyjws media type to V2_ACCEPT_HEADERS.

@lubosmj lubosmj self-assigned this Dec 13, 2023
@pulpbot pulpbot moved this to In Progress in RH Pulp Kanban board Dec 13, 2023
lubosmj added a commit to lubosmj/pulp_container that referenced this issue Dec 13, 2023
@lubosmj
Add MANIFEST_V1_SIGNED to V2_ACCEPT_HEADERS
5daaaca 
In many registries, MANIFEST_V1_SIGNED and MANIFEST_V1 is
interchangeable and considered equal.

closes pulp#1444
lubosmj added a commit to lubosmj/pulp_container that referenced this issue Dec 13, 2023
@lubosmj
Add MANIFEST_V1_SIGNED to V2_ACCEPT_HEADERS
75c545b 
In many registries, MANIFEST_V1_SIGNED and MANIFEST_V1 is
interchangeable and considered equal.

closes pulp#1444
@lubosmj lubosmj mentioned this issue Dec 13, 2023
Merged
@pulpbot pulpbot moved this from In Progress to Needs review in RH Pulp Kanban board Dec 13, 2023
@pulpbot
Copy link
Member

pulpbot commented Dec 13, 2023

https://bugzilla.redhat.com/show_bug.cgi?id=2254408

lubosmj added a commit that referenced this issue Dec 13, 2023
@lubosmj
Add MANIFEST_V1_SIGNED to V2_ACCEPT_HEADERS
2e59a91 
In many registries, MANIFEST_V1_SIGNED and MANIFEST_V1 is
interchangeable and considered equal.

closes #1444
@github-project-automation github-project-automation bot moved this from Not Started to Done in Pulp Container Roadmap Dec 13, 2023
patchback bot pushed a commit that referenced this issue Dec 13, 2023
@lubosmj @patchback
Add MANIFEST_V1_SIGNED to V2_ACCEPT_HEADERS
f0dc6b7 
In many registries, MANIFEST_V1_SIGNED and MANIFEST_V1 is
interchangeable and considered equal.

closes #1444

(cherry picked from commit 2e59a91)
@patchback patchback bot mentioned this issue Dec 13, 2023
Merged
@pulpbot pulpbot moved this from Needs review to Done in RH Pulp Kanban board Dec 13, 2023
patchback bot pushed a commit that referenced this issue Dec 13, 2023
@lubosmj @patchback
Add MANIFEST_V1_SIGNED to V2_ACCEPT_HEADERS
63e0e0b 
In many registries, MANIFEST_V1_SIGNED and MANIFEST_V1 is
interchangeable and considered equal.

closes #1444

(cherry picked from commit 2e59a91)
@patchback patchback bot mentioned this issue Dec 13, 2023
Merged
patchback bot pushed a commit that referenced this issue Dec 13, 2023
@lubosmj @patchback
Add MANIFEST_V1_SIGNED to V2_ACCEPT_HEADERS
3443ab0 
In many registries, MANIFEST_V1_SIGNED and MANIFEST_V1 is
interchangeable and considered equal.

closes #1444

(cherry picked from commit 2e59a91)
@patchback patchback bot mentioned this issue Dec 13, 2023
Merged
lubosmj added a commit that referenced this issue Dec 15, 2023
@lubosmj
Add MANIFEST_V1_SIGNED to V2_ACCEPT_HEADERS
0577741 
In many registries, MANIFEST_V1_SIGNED and MANIFEST_V1 is
interchangeable and considered equal.

closes #1444

(cherry picked from commit 2e59a91)
lubosmj added a commit that referenced this issue Dec 15, 2023
@lubosmj
Add MANIFEST_V1_SIGNED to V2_ACCEPT_HEADERS
4e9bf78 
In many registries, MANIFEST_V1_SIGNED and MANIFEST_V1 is
interchangeable and considered equal.

closes #1444

(cherry picked from commit 2e59a91)
lubosmj added a commit that referenced this issue Dec 15, 2023
@lubosmj
Add MANIFEST_V1_SIGNED to V2_ACCEPT_HEADERS
6a34d50 
In many registries, MANIFEST_V1_SIGNED and MANIFEST_V1 is
interchangeable and considered equal.

closes #1444

(cherry picked from commit 2e59a91)
@lubosmj lubosmj moved this from Done to Shipped in Pulp Container Roadmap Dec 15, 2023
@pulpbot
Copy link
Member

pulpbot commented Jan 31, 2024

https://bugzilla.redhat.com/show_bug.cgi?id=2262131

@pulpbot
Copy link
Member

pulpbot commented Feb 20, 2024

https://bugzilla.redhat.com/show_bug.cgi?id=2265149

mdellweg pushed a commit that referenced this issue Dec 4, 2024
@lubosmj @mdellweg
Add MANIFEST_V1_SIGNED to V2_ACCEPT_HEADERS
d8a94d1 
In many registries, MANIFEST_V1_SIGNED and MANIFEST_V1 is
interchangeable and considered equal.

closes #1444

(cherry picked from commit 2e59a91)
mdellweg pushed a commit that referenced this issue Dec 4, 2024
@lubosmj @mdellweg
Add MANIFEST_V1_SIGNED to V2_ACCEPT_HEADERS
f8905cb 
In many registries, MANIFEST_V1_SIGNED and MANIFEST_V1 is
interchangeable and considered equal.

closes #1444

(cherry picked from commit 2e59a91)
mdellweg pushed a commit that referenced this issue Dec 4, 2024
@lubosmj @mdellweg
Add MANIFEST_V1_SIGNED to V2_ACCEPT_HEADERS
1ac7c8d 
In many registries, MANIFEST_V1_SIGNED and MANIFEST_V1 is
interchangeable and considered equal.

closes #1444

(cherry picked from commit 2e59a91)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lubosmj lubosmj

Labels
Issue Satellite
Projects
Pulp Container Roadmap
Status: Shipped
RH Pulp Kanban board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add MANIFEST_V1_SIGNED to V2_ACCEPT_HEADERS lubosmj/pulp_container
3 participants
@ipanova @lubosmj @pulpbot