Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the manifest schema conversion machinery #1509

Closed
lubosmj opened this issue Feb 14, 2024 · 3 comments · Fixed by #1529
Closed

Remove the manifest schema conversion machinery #1509

lubosmj opened this issue Feb 14, 2024 · 3 comments · Fixed by #1529
Assignees
Labels

Comments

@lubosmj
Copy link
Member

lubosmj commented Feb 14, 2024

This feature is no longer expected to be supported or maintained.

class Schema2toSchema1ConverterWrapper:

(schema 2), the manifests are rewritten into the old format (schema 1) on-the-fly by Pulp.

@lubosmj lubosmj added the Task label Feb 14, 2024
@lubosmj
Copy link
Member Author

lubosmj commented Feb 14, 2024

Additionally, we will remove the pyjwkest dependency from our requirements.

@lubosmj
Copy link
Member Author

lubosmj commented Feb 14, 2024

In the end, we would like to return 404 in case the client is requesting docker manifest v2 schema 1 instead of accepting what is available (manifest v2 schema 2).

return await Registry.dispatch_converted_schema(tag, accepted_media_types, path)

@lubosmj
Copy link
Member Author

lubosmj commented Feb 14, 2024

Based on docker documentation (https://docker-docs.uclv.cu/registry/spec/manifest-v2-2/#backward-compatibility), we will no longer support the following procedure:

If the manifest being requested uses the new format, and the appropriate media type is not present in an Accept header, the registry will assume that the client cannot handle the manifest as-is, and rewrite it on the fly into the old format.

Which is totally acceptable.

@lubosmj lubosmj moved this from Not Started to In Progress in Pulp Container Roadmap Feb 24, 2024
git-hyagi added a commit to git-hyagi/pulp_container that referenced this issue Feb 26, 2024
git-hyagi added a commit to git-hyagi/pulp_container that referenced this issue Feb 26, 2024
git-hyagi added a commit to git-hyagi/pulp_container that referenced this issue Feb 26, 2024
git-hyagi added a commit to git-hyagi/pulp_container that referenced this issue Feb 27, 2024
git-hyagi added a commit to git-hyagi/pulp_container that referenced this issue Feb 27, 2024
git-hyagi added a commit to git-hyagi/pulp_container that referenced this issue Feb 27, 2024
git-hyagi added a commit to git-hyagi/pulp_container that referenced this issue Feb 28, 2024
git-hyagi added a commit to git-hyagi/pulp_container that referenced this issue Feb 29, 2024
git-hyagi added a commit to git-hyagi/pulp_container that referenced this issue Feb 29, 2024
git-hyagi added a commit to git-hyagi/pulp_container that referenced this issue Feb 29, 2024
git-hyagi added a commit to git-hyagi/pulp_container that referenced this issue Mar 1, 2024
@pulpbot pulpbot moved this from In Progress to Done in RH Pulp Kanban board Mar 1, 2024
@lubosmj lubosmj moved this from In Progress to Done in Pulp Container Roadmap Mar 1, 2024
lubosmj pushed a commit that referenced this issue Mar 1, 2024
@lubosmj lubosmj moved this from Done to Shipped in Pulp Container Roadmap Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Shipped
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants