Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove getttext calls within log messages #708

Merged
merged 1 commit into from
Apr 21, 2022

Conversation

lubosmj
Copy link
Member

@lubosmj lubosmj commented Apr 14, 2022

closes #690

@lubosmj lubosmj force-pushed the audit-ilnlogs-gettext-690 branch from ba98fa5 to cdf2654 Compare April 14, 2022 10:18
@lubosmj
Copy link
Member Author

lubosmj commented Apr 14, 2022

I am not sure whether we should also refactor i18l messages within RuntimeError exceptions. These types of messages are not directly shown to users but rather to administrators in standard error logs. Do you think I should also remove the remaining gettext calls from any other uncaught exceptions (which result in HTTP 500 responses)?

@lubosmj lubosmj marked this pull request as ready for review April 14, 2022 10:26
@mdellweg
Copy link
Member

I am not sure whether we should also refactor i18l messages within RuntimeError exceptions. These types of messages are not directly shown to users but rather to administrators in standard error logs. Do you think I should also remove the remaining gettext calls from any other uncaught exceptions (which result in HTTP 500 responses)?

That is not a bad idea. But i want to see more peoples opinions.

@ipanova
Copy link
Member

ipanova commented Apr 14, 2022

I am not sure whether we should also refactor i18l messages within RuntimeError exceptions. These types of messages are not directly shown to users but rather to administrators in standard error logs. Do you think I should also remove the remaining gettext calls from any other uncaught exceptions (which result in HTTP 500 responses)?

That is not a bad idea. But i want to see more peoples opinions.

+1. @bmbouter since you're working on the pulpcore issue

@lubosmj
Copy link
Member Author

lubosmj commented Apr 19, 2022

We concluded that if it is either a log entry or traceback, we should not use i8ln.

@lubosmj lubosmj marked this pull request as draft April 19, 2022 18:46
@lubosmj lubosmj force-pushed the audit-ilnlogs-gettext-690 branch from cdf2654 to 262d2f3 Compare April 20, 2022 19:11
@lubosmj lubosmj marked this pull request as ready for review April 20, 2022 19:51
@lubosmj lubosmj requested review from ipanova and mdellweg April 20, 2022 19:51
@mdellweg
Copy link
Member

Nitpick s/getttext/gettext/ in the commit message.

@lubosmj lubosmj force-pushed the audit-ilnlogs-gettext-690 branch from 262d2f3 to 91708f7 Compare April 21, 2022 12:29
@lubosmj lubosmj merged commit e50b01d into pulp:main Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit log statements for i18n
3 participants