-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed 404 during sync from registry.redhat.io #976
Conversation
FYI I still cannot create a local reproducer because it is not that easy to hit the point when the token expires during the image manifest request by digest https://access.redhat.com/articles/6138332 |
0a0e005
to
bdbc517
Compare
@ianballou what's the earliest pulp-container version you want this backported to ? |
@ipanova the very earliest would be 2.8 |
Whenever a token expires a new token is requested. The 404 sync problem was triggered because the accept headers that were passed originally with the expired token were not passed to the re-newed token. As a result the registry was redirecting to the wrong schema version (schema1, which is unsupported since july 2022 https://access.redhat.com/articles/6138332) because of absense of the accept headers. closes pulp#974
Backport to 2.10: 💚 backport PR created✅ Backport PR branch: Backported as #997 🤖 @patchback |
Backport to 2.9: 💚 backport PR created✅ Backport PR branch: Backported as #998 🤖 @patchback |
Backport to 2.8: 💚 backport PR created✅ Backport PR branch: Backported as #999 🤖 @patchback |
Backport to 2.11: 💚 backport PR created✅ Backport PR branch: Backported as #1000 🤖 @patchback |
Backport to 2.12: 💚 backport PR created✅ Backport PR branch: Backported as #1001 🤖 @patchback |
Backport to 2.13: 💚 backport PR created✅ Backport PR branch: Backported as #1002 🤖 @patchback |
to help with the reproducer one can set |
Whenever a token expires a new token is requested.
The 404 sync problem was triggered because the accept headers that
were passed originally with the expired token were not passed to the
re-newed token. As a result the registry was redirecting to the wrong
schema version (schema1, which is unsupported since july 2022
https://access.redhat.com/articles/6138332) because of absense of the
accept headers.
closes #974