Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed 404 during sync from registry.redhat.io #976

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Conversation

ipanova
Copy link
Member

@ipanova ipanova commented Aug 17, 2022

Whenever a token expires a new token is requested.
The 404 sync problem was triggered because the accept headers that
were passed originally with the expired token were not passed to the
re-newed token. As a result the registry was redirecting to the wrong
schema version (schema1, which is unsupported since july 2022
https://access.redhat.com/articles/6138332) because of absense of the
accept headers.

closes #974

@ipanova
Copy link
Member Author

ipanova commented Aug 17, 2022

FYI I still cannot create a local reproducer because it is not that easy to hit the point when the token expires during the image manifest request by digest https://access.redhat.com/articles/6138332

@ipanova ipanova force-pushed the i974 branch 2 times, most recently from 0a0e005 to bdbc517 Compare August 17, 2022 20:15
@ipanova
Copy link
Member Author

ipanova commented Aug 17, 2022

@ianballou what's the earliest pulp-container version you want this backported to ?

@ipanova ipanova requested a review from dkliban August 17, 2022 20:18
CHANGES/974.bugfix Outdated Show resolved Hide resolved
@ianballou
Copy link
Contributor

@ipanova the very earliest would be 2.8

Whenever a token expires a new token is requested.
The 404 sync problem was triggered because the accept headers that
were passed originally with the expired token were not passed to the
re-newed token. As a result the registry was redirecting to the wrong
schema version (schema1, which is unsupported since july 2022
https://access.redhat.com/articles/6138332) because of absense of the
accept headers.

closes pulp#974
@patchback
Copy link

patchback bot commented Aug 22, 2022

Backport to 2.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/2.10/16e104ff0b2bf1ca86003a875b13bf1bbdc1c792/pr-976

Backported as #997

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link

patchback bot commented Aug 22, 2022

Backport to 2.9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/2.9/16e104ff0b2bf1ca86003a875b13bf1bbdc1c792/pr-976

Backported as #998

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link

patchback bot commented Aug 22, 2022

Backport to 2.8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/2.8/16e104ff0b2bf1ca86003a875b13bf1bbdc1c792/pr-976

Backported as #999

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link

patchback bot commented Aug 22, 2022

Backport to 2.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/2.11/16e104ff0b2bf1ca86003a875b13bf1bbdc1c792/pr-976

Backported as #1000

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link

patchback bot commented Aug 22, 2022

Backport to 2.12: 💚 backport PR created

✅ Backport PR branch: patchback/backports/2.12/16e104ff0b2bf1ca86003a875b13bf1bbdc1c792/pr-976

Backported as #1001

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link

patchback bot commented Aug 22, 2022

Backport to 2.13: 💚 backport PR created

✅ Backport PR branch: patchback/backports/2.13/16e104ff0b2bf1ca86003a875b13bf1bbdc1c792/pr-976

Backported as #1002

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@ipanova
Copy link
Member Author

ipanova commented Feb 27, 2023

FYI I still cannot create a local reproducer because it is not that easy to hit the point when the token expires during the image manifest request by digest https://access.redhat.com/articles/6138332

to help with the reproducer one can set TOKEN_EXPIRATION_TIME to a lower value than the default 300s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repo sync from RH registry fails with 404
4 participants