Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Badly configured webservers break treeinfo detection #3599

Closed
dralley opened this issue Jun 14, 2024 · 0 comments · Fixed by #3600
Closed

Badly configured webservers break treeinfo detection #3599

dralley opened this issue Jun 14, 2024 · 0 comments · Fixed by #3600
Labels
Issue

Comments

@dralley
Copy link
Contributor

dralley commented Jun 14, 2024

Version
Any

Describe the bug
Some webservers return 200 with an HTML error page instead of returning 404 when a non-existing resource is requested. This breaks Pulp, and you end up with errors like this:

https://github.com/pulp/pulp_rpm/actions/runs/9509963612/job/26230632854#step:14:2404

To Reproduce
Steps to reproduce the behavior:

Expected behavior
A clear and concise description of what you expected to happen.

Additional context
Add any other context about the problem here. Please provide links to any previous discussions via Discourse or Bugzilla.
dralley added a commit to dralley/pulp_rpm that referenced this issue Jun 14, 2024
@dralley
Made sync more tolerant of poorly configured webservers
19ed8ec 
Treeinfo download will ignore results that look like HTML. Some
webservers return 200 with an HTML error page rather than 404.

closes pulp#3599
@dralley dralley mentioned this issue Jun 14, 2024
Merged
@pulpbot pulpbot moved this to Needs review in RH Pulp Kanban board Jun 14, 2024
dralley added a commit to dralley/pulp_rpm that referenced this issue Jun 14, 2024
@dralley
Made sync more tolerant of poorly configured webservers
480a91e 
Treeinfo download will ignore results that look like HTML. Some
webservers return 200 with an HTML error page rather than 404.

closes pulp#3599
dralley added a commit to dralley/pulp_rpm that referenced this issue Jun 14, 2024
@dralley
Made sync more tolerant of poorly configured webservers
2f72534 
Treeinfo download will ignore results that look like HTML. Some
webservers return 200 with an HTML error page rather than 404.

closes pulp#3599
dralley added a commit to dralley/pulp_rpm that referenced this issue Jun 14, 2024
@dralley
Made sync more tolerant of poorly configured webservers
f955d5f 
Treeinfo download will ignore results that look like HTML. Some
webservers return 200 with an HTML error page rather than 404.

closes pulp#3599
dralley added a commit to dralley/pulp_rpm that referenced this issue Jun 14, 2024
@dralley
Made sync more tolerant of poorly configured webservers
7735537 
Treeinfo download will ignore results that look like HTML. Some
webservers return 200 with an HTML error page rather than 404.

closes pulp#3599
dralley added a commit to dralley/pulp_rpm that referenced this issue Jun 14, 2024
@dralley
Made sync more tolerant of poorly configured webservers
566b530 
Treeinfo download will ignore results that look like HTML. Some
webservers return 200 with an HTML error page rather than 404.

closes pulp#3599
ggainey pushed a commit that referenced this issue Jun 14, 2024
@dralley @ggainey
Made sync more tolerant of poorly configured webservers
298f3a9 
Treeinfo download will ignore results that look like HTML. Some
webservers return 200 with an HTML error page rather than 404.

closes #3599
@pulpbot pulpbot moved this from Needs review to Done in RH Pulp Kanban board Jun 14, 2024
patchback bot pushed a commit that referenced this issue Jun 14, 2024
@dralley @patchback
Made sync more tolerant of poorly configured webservers
ecaa714 
Treeinfo download will ignore results that look like HTML. Some
webservers return 200 with an HTML error page rather than 404.

closes #3599

(cherry picked from commit 298f3a9)
patchback bot pushed a commit that referenced this issue Jun 14, 2024
@dralley @patchback
Made sync more tolerant of poorly configured webservers
0ceaa5f 
Treeinfo download will ignore results that look like HTML. Some
webservers return 200 with an HTML error page rather than 404.

closes #3599

(cherry picked from commit 298f3a9)
This was referenced Jun 14, 2024
Merged
Merged
patchback bot pushed a commit that referenced this issue Jun 14, 2024
@dralley @patchback
Made sync more tolerant of poorly configured webservers
df1415d 
Treeinfo download will ignore results that look like HTML. Some
webservers return 200 with an HTML error page rather than 404.

closes #3599

(cherry picked from commit 298f3a9)
@patchback patchback bot mentioned this issue Jun 14, 2024
Merged
ggainey pushed a commit that referenced this issue Jun 14, 2024
@dralley @ggainey
Made sync more tolerant of poorly configured webservers
6d1c2eb 
Treeinfo download will ignore results that look like HTML. Some
webservers return 200 with an HTML error page rather than 404.

closes #3599

(cherry picked from commit 298f3a9)
ggainey pushed a commit that referenced this issue Jun 14, 2024
@dralley @ggainey
Made sync more tolerant of poorly configured webservers
c310065 
Treeinfo download will ignore results that look like HTML. Some
webservers return 200 with an HTML error page rather than 404.

closes #3599

(cherry picked from commit 298f3a9)
ggainey pushed a commit that referenced this issue Jun 14, 2024
@dralley @ggainey
Made sync more tolerant of poorly configured webservers
846a141 
Treeinfo download will ignore results that look like HTML. Some
webservers return 200 with an HTML error page rather than 404.

closes #3599

(cherry picked from commit 298f3a9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue
Projects
No open projects
RH Pulp Kanban board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Made sync more tolerant of poorly configured webservers dralley/pulp_rpm
2 participants
@dralley @ggainey