Add ClientConnectionError as retriable exception on content-app strea…

…ming

A user reported that after changing the host and resyncing they
would have some some leftover RAs with the invalid url, and that would
raise an aiohttp.client_exceptions.ClientConnectionError.

Because that is not a retriable error for content streaming,
the right RA wouldnt be tried afterwards.

Fixes #5967

(cherry picked from commit 9b5d907)

CHANGES/5967.bugfix

@@ -0,0 +1,2 @@
+On the content-app, added ClientConnectionError (aiohttp) as an exception that can trigger
+a retry when streaming content from a Remote.

pulpcore/content/handler.py

@@ -5,7 +5,7 @@
 import re
 from gettext import gettext as _
 
-from aiohttp.client_exceptions import ClientResponseError
+from aiohttp.client_exceptions import ClientResponseError, ClientConnectionError
 from aiohttp.web import FileResponse, StreamResponse, HTTPOk
 from aiohttp.web_exceptions import (
     HTTPError,
@@ -756,6 +756,13 @@ async def _stream_content_artifact(self, request, response, content_artifact):
                 :class:`~pulpcore.plugin.models.ContentArtifact` returned the binary data needed for
                 the client.
         """
+        # We should only retry with exceptions that happen before we receive any data
+        # and start streaming, as we can't rollback data if something happens after that.
+        RETRYABLE_EXCEPTIONS = (
+            ClientResponseError,
+            UnsupportedDigestValidationError,
+            ClientConnectionError,
+        )
 
         remote_artifacts = content_artifact.remoteartifact_set.select_related(
             "remote"
@@ -764,8 +771,7 @@ async def _stream_content_artifact(self, request, response, content_artifact):
             try:
                 response = await self._stream_remote_artifact(request, response, remote_artifact)
                 return response
-
-            except (ClientResponseError, UnsupportedDigestValidationError) as e:
+            except RETRYABLE_EXCEPTIONS as e:
                 log.warning(
                     "Could not download remote artifact at '{}': {}".format(
                         remote_artifact.url, str(e)