Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RBAC guide for plugin writers #2494

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Conversation

mdellweg
Copy link
Member

@mdellweg mdellweg commented Apr 7, 2022

Explain the concept of roles, their relationship to permissions, how
they are associated with personas and objects and also remove any
mention of django-guardian that is to be removed in 3.20.

fixes #2463

@mdellweg mdellweg force-pushed the rbac_docs branch 2 times, most recently from b2e2c5f to b4e7aa1 Compare April 7, 2022 10:41
@bmbouter
Copy link
Member

bmbouter commented Apr 7, 2022

This is all pretty good. What I really think would benefit this is a clear example, like one from pulp_file. If an example could be picked, e.g. FileRemote and then use that as the context to concretely talk about each thing I think it would do wonders to connect the abstract language (which is needed) to the concrete implementation of that (also needed).

@mdellweg mdellweg force-pushed the rbac_docs branch 3 times, most recently from 0476796 to c234341 Compare April 8, 2022 16:04
@mdellweg mdellweg marked this pull request as ready for review April 12, 2022 10:36
@mdellweg mdellweg changed the title WIP: Update RBAC guide for plugin writers Update RBAC guide for plugin writers Apr 12, 2022
@ipanova ipanova requested review from bmbouter, gerrod3 and ipanova April 12, 2022 13:30

DRF_ACCESS_POLICY = {"reusable_conditions": "pulpcore.app.global_access_conditions"}
:Model-Level: A role is associated to a user or group for access to a specific model, but not an
instance of that model. This allows you to express concepts like "Hilde can administer all
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of Hilde as a specific user persona.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nih

Copy link
Member

@bmbouter bmbouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very tiny optional comments left. Thanks for doing this!

Explain the concept of roles, their relationship to permissions, how
they are associated with personas and objects and also remove any
mention of django-guardian that is to be removed in 3.20.

fixes pulp#2463

Co-authored-by: Ina Panova <ipanova@redhat.com>
Co-authored-by: bmbouter <bmbouter@gmail.com>
Co-authored-by: Gerrod <gerrodubben@gmail.com>
Copy link
Member

@ipanova ipanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update plugin writers docs for RBAC
4 participants