-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RBAC guide for plugin writers #2494
Conversation
b2e2c5f
to
b4e7aa1
Compare
This is all pretty good. What I really think would benefit this is a clear example, like one from pulp_file. If an example could be picked, e.g. FileRemote and then use that as the context to concretely talk about each thing I think it would do wonders to connect the abstract language (which is needed) to the concrete implementation of that (also needed). |
0476796
to
c234341
Compare
|
||
DRF_ACCESS_POLICY = {"reusable_conditions": "pulpcore.app.global_access_conditions"} | ||
:Model-Level: A role is associated to a user or group for access to a specific model, but not an | ||
instance of that model. This allows you to express concepts like "Hilde can administer all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice use of Hilde
as a specific user persona.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nih
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very tiny optional comments left. Thanks for doing this!
Explain the concept of roles, their relationship to permissions, how they are associated with personas and objects and also remove any mention of django-guardian that is to be removed in 3.20. fixes pulp#2463 Co-authored-by: Ina Panova <ipanova@redhat.com> Co-authored-by: bmbouter <bmbouter@gmail.com> Co-authored-by: Gerrod <gerrodubben@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Explain the concept of roles, their relationship to permissions, how
they are associated with personas and objects and also remove any
mention of django-guardian that is to be removed in 3.20.
fixes #2463