Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #4176/4ced14e9 backport][3.28] Moves TaskGroup.finish() to outside the loop in the replication task #4178

Merged
merged 1 commit into from
Jul 28, 2023
Merged

[PR #4176/4ced14e9 backport][3.28] Moves TaskGroup.finish() to outside the loop in the replication task #4178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGES/4175.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fixed bug where the Task Group for replication would be marked as fully dispatched after just one
replicator.
2 changes: 1 addition & 1 deletion pulpcore/app/tasks/replica.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,4 +98,4 @@ def replicate_distributions(server_pk):
distro_names.append(distro["name"])

replicator.remove_missing(distro_names)
task_group.finish()
task_group.finish()