Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid automatic encoding for fixture server #4494

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

hstct
Copy link
Contributor

@hstct hstct commented Sep 26, 2023

This is a fix that was added to pulp-smash but is missing here.

See more here:

pulp/pulp-smash#1309
pulp/pulp-smash@a18afe9


It also speeds up local testing (at least in pulp_deb) because it will no longer try to verify the encoding of extracted archive files 4 times before failing. Which looks like this:

9d1d6ce495d7 Giving up download_wrapper(...) after 4 tries (pulpcore.exceptions.validation.DigestValidationError: A file located at the url http://127.0.0.1:59071/debian-update/dists/ragnarok/jotunheimr/binary-armeb/Packages.gz failed validation due to checksum. Expected 'c3d96859b1edfce90bfb47928dad84b0616d9322d6df5a8a8a704d361ab78930', Actual '6a5079388629eacffc797c85b9083d1153db91cf9bc124be4f4dac33fa0647a3')
9d1d6ce495d7 pulp [af77c374-19b8-4c87-9120-70d9e4e82331]: backoff:ERROR: Giving up download_wrapper(...) after 4 tries (pulpcore.exceptions.validation.DigestValidationError: A file located at the url http://127.0.0.1:59071/debian-update/dists/ragnarok/jotunheimr/binary-armeb/Packages.gz failed validation due to checksum. Expected 'c3d96859b1edfce90bfb47928dad84b0616d9322d6df5a8a8a704d361ab78930', Actual '6a5079388629eacffc797c85b9083d1153db91cf9bc124be4f4dac33fa0647a3')
9d1d6ce495d7 pulp [af77c374-19b8-4c87-9120-70d9e4e82331]: pulp_deb.app.tasks.synchronizing:INFO: Digest for artifact with relative_path='dists/ragnarok/jotunheimr/binary-armeb/Packages.gz' not matched. Ignored

@hstct
Copy link
Contributor Author

hstct commented Sep 26, 2023

It would be really great if that change could be backported to at least pulpcore 3.28 so we don't need to increase the requirements again :)

@dkliban dkliban merged commit da4fe01 into pulp:main Sep 26, 2023
14 checks passed
@patchback
Copy link

patchback bot commented Sep 26, 2023

Backport to 3.28: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.28/da4fe01b2730bd90d29185b90a10026f595d157d/pr-4494

Backported as #4504

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link

patchback bot commented Sep 26, 2023

Backport to 3.35: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.35/da4fe01b2730bd90d29185b90a10026f595d157d/pr-4494

Backported as #4505

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants