Add domain and task argument support to TaskSchedule. #5779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decko
force-pushed
the
add_domain_and_args_support_task_schedule
branch
from
357e61e
to
5b7a5dd
Compare
lubosmj
reviewed
Sep 10, 2024
| @@ -8,7 +8,7 @@ | |||
| Pulp supports scheduling of tasks. Scheduled tasks will be dispatched shortly after their | |||
| `next_dispatch` time, and be rescheduled one `dispatch_interval` after that, if the latter is | |||
| set. By specifying the `dispatch_interval` as `time_delta(days=1)` you can expect the task | |||
| dispatch to stabily happen at same time every day. Until the last task of the same schedule enters a | |||
| dispatch to stably happen at same time every day. Until the last task of the same schedule enters a | |||
There was a problem hiding this comment.
Suggested change
| dispatch to stably happen at same time every day. Until the last task of the same schedule enters a | |
| dispatch to stably happen at the same time every day. Until the last task of the same schedule enters a |
lubosmj
reviewed
Sep 10, 2024
| @@ -371,6 +372,8 @@ class TaskSchedule(BaseModel): | |||
| dispatch_interval = models.DurationField(null=True) | |||
| task_name = models.TextField() | |||
| last_task = models.ForeignKey(Task, null=True, on_delete=models.SET_NULL) | |||
| pulp_domain = models.ForeignKey(Domain, null=True, on_delete=models.CASCADE) | |||
| task_args = models.TextField(null=True) | |||
There was a problem hiding this comment.
Should we use here JSONField instead: https://docs.djangoproject.com/en/4.2/ref/models/fields/#jsonfield? It appears to be much more safe than calling ast.
There was a problem hiding this comment.
Great idea. Gonna work on that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5778