Show an event marker for particular dates #28
+194
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is wonderful, but I'm a little hesitant to adopt anything that brings its own appearance to the party. Just a couple tweaks and it could be fine. |
| @@ -127,11 +125,14 @@ - (void)setBeginningDate:(NSDate *)date; | |||
|
|
|||
| for (NSUInteger index = 0; index < self.daysInWeek; index++) { | |||
| NSString *title = [self.dayFormatter stringFromDate:date]; | |||
| NSString *subTitle = [self.calendarView shouldDisplayEventMarkerForDate:date] ? @"•" : nil; | |||
There was a problem hiding this comment.
Could you extract this logic out? Have a -setEventMarkerVisible:(BOOL)visible forColumnAtIndex:(NSUInteger)index; that does this and can be overridden by the subclass.
There was a problem hiding this comment.
I had a look at this, and I ran into a problem in -[selectColumnForDate:] where the day button's properties get copied to the selected button. Would it be OK instead to change the button class so it had an eventMarkerVisible property?
added 3 commits
May 11, 2013 09:50
|
Hi guys, Eager to see this functionality available on master. Could we go ahead and merge back these changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a method to the calendar delegate,
-calendarView:shouldDisplayEventMarkerForDate:, which allows the delegate to specify that a marker should be displayed under the number.The marker is the bullet character '•' so no additional images are required, and the delegate method is optional so this shouldn't break any existing installations.