-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicity set contextIsolation for Electron 12 #1
base: master
Are you sure you want to change the base?
Conversation
This can't be right - I'm already using Electron 12 for a while, and we're not experiencing this problem. If I'm not mistaken, contextIsolation doesn't even exist on newer electron versions, so I don't think we can rely on it anyway... |
I believe that I either tinkered with that setting while we were doing the initial rebrand, or it was already explicitly set |
Either way, we do need it for the time being. However, we should probably search for all instances of |
Did you try to open the Github window in the editor? |
Yes, you or @mauricioszabo did that for the editor when bumping to Electron 12: https://github.com/pulsar-edit/pulsar/pull/54/files#diff-23441b1e2ecd41b45a9b24a1f2bbf6af72c96396d34409560a5441813591179dR58 |
Yes, and it's working, why? What exactly are the problems you've been experiencing? |
I'm seeing it the log and I believe it's not working and the fix is needed. However, I'm not experiencing any visual bug. Considering, the code is from a worker, and I'm not familiar with the package, I'm unsure what kind of visual bug we'll see. Still, I'll leave PR here if anyone has any problem with Github package. Regarding |
Description of the Change
Since Electron 12, the default of
contextIsolation
has changed totrue
fromfalse
so we'll have to set it tofalse
explicitly. Otherwise, Node APIs won't be used in renderer processes. Example of error in the console:See electron/electron#23506 for more information.
Screenshot or Gif
N/A
Applicable Issues
N/A