Implement Repo Tests #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally adding in the `package-lock.json` as it's best practice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On this PR I've setup updated tests, while additionally ensuring we are testing against every platform, and multiple versions of node, as the last version ever tested for here was NodeJS 6 it seems.
I've also purposefully added the
package-lock.jsonfile as it's best practice nowadays to have it available.Part of the purpose of this, is when attempting to run testing with zero changes locally, I was seeing failures. This can help determine if those tests are platform specific, or uncaught bugs within this package, or this NodeJS version