Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test failure due to missing atom command #124

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Fix test failure due to missing atom command #124

merged 2 commits into from
Feb 1, 2024

Conversation

toddy15
Copy link
Contributor

@toddy15 toddy15 commented Jan 29, 2024

If pulsar is installed from the .deb package,
the command ppm test fails with this error:

Error spawning atom: spawn atom ENOENT

Using pulsar instead of atom fixes this.

If pulsar is installed from the .deb package,
the command 'ppm test' fails with this error:

Error spawning atom: spawn atom ENOENT

Using pulsar instead of atom fixes this.
@toddy15
Copy link
Contributor Author

toddy15 commented Jan 30, 2024

I did not update spec/test-spec.js, this is fixed now. Hopefully all tests should now pass.

Copy link
Member

@DeeDeeG DeeDeeG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix! (And for updating the associated test file.)

Looks good to me 👍

@DeeDeeG

This comment was marked as off-topic.

@DeeDeeG
Copy link
Member

DeeDeeG commented Feb 1, 2024

CI is passing, thanks again! Merging now. 👍

EDIT to add: We need to do a PR to update core repo to use this updated version of ppm. It can be expected to be included in Pulsar regular 1.114 release, and possibly Rolling before that. Core team will generally handle this as time permits, but I wouldn't be against a PR to do so from any contributor, but nor is it expected.

@DeeDeeG DeeDeeG merged commit 7237881 into pulsar-edit:master Feb 1, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants