Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decaffeinate enable spec #72

Merged
merged 3 commits into from
May 21, 2023
Merged

Decaffeinate enable spec #72

merged 3 commits into from
May 21, 2023

Conversation

2colours
Copy link
Contributor

Meant to supersede #28.
Again, no modifications happened in the meantime so all I did was to readd the semicolons...

DeeDeeG
DeeDeeG approved these changes May 21, 2023
View reviewed changes
Copy link
Member

@DeeDeeG DeeDeeG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem good.

And again, no failing tests in CI.

confused-Techie
confused-Techie approved these changes May 21, 2023
View reviewed changes
Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Passing tests, clean diff, and all around a rad PR.

Like mentioned otherwise just putting in some breathing room, but didn't feel the need of taking up your time with it. Will merge this one, thanks!

@confused-Techie confused-Techie merged commit 700d1d5 into pulsar-edit:decaf May 21, 2023
@2colours 2colours deleted the decaffeinate-enable-spec branch May 21, 2023 08:13
@DeeDeeG DeeDeeG mentioned this pull request Sep 8, 2023
Closed
@DeeDeeG DeeDeeG mentioned this pull request Sep 17, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@confused-Techie confused-Techie confused-Techie approved these changes

@DeeDeeG DeeDeeG DeeDeeG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@2colours @DeeDeeG @confused-Techie @GuilleW