Various Revisions #8

confused-Techie · 2022-09-26T08:35:55Z

This PR covers several points of concern for the repo.

While this is still in progress the already completed/intended to be complete areas are:

Decaffeinate everything, from specs to src.
- A note on decaffeination, while it may not be the prettiest code, it was decaffeinated with the tools that automatically did it during building. Meaning it should be nearly the exact some code that has been shipped so far. Exempt in some key areas:
  - Obvious uses of var are being replaced with the appropriate let or const
  - Additionally any instances of internal Express Servers being used are being rewritten, more on that later.
  - Pointless returns are being removed as needed.
Updates some dependencies:
- express 4.17.1 => 4.18.1
- node-gyp 5.1.1 => 9.1.0
Express Server code is being rewritten with modern conventions and syntax, to be more accessible to those newer with the platform, so that their docs match what we have.
All Coffee related dependencies and scripts have been removed
Scripts have been modified to support Windows systems that contain a path in the name. This resolves PR Support Windows System with Space in Path #4, while ignored whatever formatting error that happened on that PR.

Some things that should still be high priority to complete even if not present in this PR.

We should get git-utils to rely on our own fork. Although our fork doesn't seem to contain the tagged version referenced in our dependency. And downgrading to 5.7.0 produces many errors, and will likely have to be revisited.
Ideally we can move away from custom implementations of Jasmine like we have here jasmine-focused, which relies on a specific commit of kevinsawicki/jasmine-node which itself is forked from mhevery/jasmine-node meanwhile jasmine supports node just fine at modern versions and could likely save us some headache of finding documentation. But unfortunately our current tests rely on some features that no longer or have never existed on normal jasmine, so those will have to get significant rewrites to work.

Otherwise this PR will remain a draft until work is done on properly decaffeinating and properly rewriting the Express code.

Feel free to add more here, especially around dependencies, as I'd like to get everything updated that we can without to many mysterious test failures, and switch over to all of our forks for dependencies as much as possible.

… Middleware

codacy-production · 2022-10-30T01:47:14Z

spec/uninstall-spec.js

+    };
+  };
+
+  describe('apm uninstall', function() {


Codacy has a fix for the issue: Replace 'apm·uninstall',·function with "apm·uninstall",·function·

Suggested change

describe('apm uninstall', function() {

describe("apm uninstall", function () {

codacy-production · 2022-10-30T01:47:15Z

spec/develop-spec.js

+      spyOnToken();
+      atomHome = temp.mkdirSync('apm-home-dir-');
+      process.env.ATOM_HOME = atomHome;
+      atomReposHome = temp.mkdirSync('apm-repos-home-dir-');


Codacy has a fix for the issue: Replace 'apm-repos-home-dir-' with "apm-repos-home-dir-"

Suggested change

atomReposHome = temp.mkdirSync('apm-repos-home-dir-');

atomReposHome = temp.mkdirSync("apm-repos-home-dir-");

codacy-production · 2022-10-30T01:47:16Z

lib/init.js

+        return function(error) {
+          var templatePath;
+          if (error != null) {
+            return callback(error);


Codacy has a fix for the issue: Insert ··

Suggested change

return callback(error);

return callback(error);

codacy-production · 2022-10-30T01:47:17Z

spec/test-spec.js

+      var currentDir;
+      silenceOutput();
+      spyOnToken();
+      currentDir = temp.mkdirSync('apm-init-');


Codacy has a fix for the issue: Replace 'apm-init-' with "apm-init-"

Suggested change

currentDir = temp.mkdirSync('apm-init-');

currentDir = temp.mkdirSync("apm-init-");

codacy-production · 2022-10-30T01:47:18Z

lib/git.js

+      userconfig: config.getUserConfigPath(),
+      globalconfig: config.getGlobalConfigPath()
+    };
+    return npm.load(npmOptions, function() {


Codacy has a fix for the issue: Insert ·

Suggested change

return npm.load(npmOptions, function() {

return npm.load(npmOptions, function () {

codacy-production · 2022-10-30T01:47:20Z

spec/list-spec.js

+        return expect(lines.join("\n")).not.toContain('.bin');
+      });
+    });
+    describe('enabling and disabling packages', function() {


Codacy has a fix for the issue: Replace 'enabling·and·disabling·packages',·function with "enabling·and·disabling·packages",·function·

Suggested change

describe('enabling and disabling packages', function() {

describe("enabling and disabling packages", function () {

codacy-production · 2022-10-30T01:47:21Z

spec/rebuild-spec.js

+      app.get('/node/v10.20.1/node-v10.20.1.tar.gz', function(request, response) {
+        return response.sendFile(path.join(__dirname, 'fixtures', 'node-v10.20.1.tar.gz'));
+      });
+      app.get('/node/v10.20.1/node-v10.20.1-headers.tar.gz', function(request, response) {


Codacy has a fix for the issue: Replace '/node/v10.20.1/node-v10.20.1-headers.tar.gz',·function with ⏎········"/node/v10.20.1/node-v10.20.1-headers.tar.gz",⏎········function·

Suggested change

app.get('/node/v10.20.1/node-v10.20.1-headers.tar.gz', function(request, response) {

app.get(

codacy-production · 2022-10-30T01:47:22Z

spec/stars-spec.js

+      });
+      server = http.createServer(app);
+      live = false;
+      server.listen(3000, '127.0.0.1', function() {


Codacy has a fix for the issue: Replace '127.0.0.1',·function with "127.0.0.1",·function·

Suggested change

server.listen(3000, '127.0.0.1', function() {

server.listen(3000, "127.0.0.1", function () {

codacy-production · 2022-10-30T01:47:23Z

lib/link.js

+      return options.alias('d', 'dev').boolean('dev').describe('dev', 'Link to ~/.atom/dev/packages');
+    };
+
+    Link.prototype.run = function(options) {


Codacy has a fix for the issue: Insert ·

Suggested change

Link.prototype.run = function(options) {

Link.prototype.run = function (options) {

codacy-production · 2022-10-30T01:47:25Z

lib/upgrade.js

+        return;
+      }
+      try {
+        metadata = JSON.parse(fs.readFileSync(path.join(packageDirectory, 'package.json')));


Codacy has a fix for the issue: Replace fs.readFileSync(path.join(packageDirectory,·'package.json')) with ⏎··········fs.readFileSync(path.join(packageDirectory,·"package.json"))⏎········

Suggested change

metadata = JSON.parse(fs.readFileSync(path.join(packageDirectory, 'package.json')));

metadata = JSON.parse(

codacy-production · 2022-10-30T01:47:26Z

lib/list.js

+      var configPath, ref, ref1, ref2;
+      List.__super__.constructor.call(this);
+      this.userPackagesDirectory = path.join(config.getAtomDirectory(), 'packages');
+      this.devPackagesDirectory = path.join(config.getAtomDirectory(), 'dev', 'packages');


Codacy has a fix for the issue: Replace config.getAtomDirectory(),·'dev',·'packages' with ⏎········config.getAtomDirectory(),⏎········"dev",⏎········"packages"⏎······

Suggested change

this.devPackagesDirectory = path.join(config.getAtomDirectory(), 'dev', 'packages');

this.devPackagesDirectory = path.join(

codacy-production · 2022-10-30T01:47:27Z

spec/test-spec.js

+(function() {
+  var apm, child_process, fs, path, temp;
+
+  child_process = require('child_process');


Codacy has a fix for the issue: Replace 'child_process' with "child_process"

Suggested change

child_process = require('child_process');

child_process = require("child_process");

codacy-production · 2022-10-30T01:47:28Z

lib/text-mate-theme.js

+
+  _ = require('underscore-plus');
+
+  plist = require('@atom/plist');


Codacy has a fix for the issue: Replace '@atom/plist' with "@atom/plist"

Suggested change

plist = require('@atom/plist');

plist = require("@atom/plist");

codacy-production · 2022-10-30T01:47:29Z

lib/text-mate-theme.js

+      this.syntaxVariables = SyntaxVariablesTemplate;
+      for (key in settings) {
+        value = settings[key];
+        replaceRegex = new RegExp("\\{\\{" + key + "\\}\\}", 'g');


Codacy has a fix for the issue: Replace 'g' with "g"

Suggested change

replaceRegex = new RegExp("\\{\\{" + key + "\\}\\}", 'g');

replaceRegex = new RegExp("\\{\\{" + key + "\\}\\}", "g");

codacy-production · 2022-10-30T01:47:30Z

spec/enable-spec.js

+      return runs(function() {
+        var config;
+        expect(console.log).toHaveBeenCalled();
+        expect(console.log.argsForCall[0][0]).toMatch(/Not Disabled:\s*not-installed/);


Codacy has a fix for the issue: Replace /Not·Disabled:\s*not-installed/ with ⏎··········/Not·Disabled:\s*not-installed/⏎········

Suggested change

expect(console.log.argsForCall[0][0]).toMatch(/Not Disabled:\s*not-installed/);

expect(console.log.argsForCall[0][0]).toMatch(

codacy-production · 2022-10-30T01:47:31Z

lib/list.js

@@ -0,0 +1,311 @@
+// Generated by CoffeeScript 1.12.7
+(function() {


Codacy has a fix for the issue: Insert ·

Suggested change

(function() {

(function () {

codacy-production · 2022-10-30T01:47:32Z

lib/package-converter.js

+
+  zlib = require('zlib');
+
+  _ = require('underscore-plus');


Codacy has a fix for the issue: Replace 'underscore-plus' with "underscore-plus"

Suggested change

_ = require('underscore-plus');

_ = require("underscore-plus");

codacy-production · 2022-10-30T01:47:33Z

spec/disable-spec.js

@@ -0,0 +1,127 @@
+// Generated by CoffeeScript 1.12.7
+(function() {


Codacy has a fix for the issue: Insert ·

Suggested change

(function() {

(function () {

DeeDeeG · 2022-11-01T01:37:29Z

Just a brief comment, the node-gyp dependency being separate was only to resolve a quirk during testing -- depending on how how deeply or shallowly nested npm decides to hoist the node-gyp module under node_modules folder, its path can change. Whereas there is one spec that tries to copy node-gyp from its herd-coded path under node_modules.

Amin decided to pin a separate copy of node-gyp so it would always be hoisted to top-level. This was done over at the atom-community/apm repo.

Thes copy won't actually be used in real-world usage, only the copy required by npm will actually be used, so I recommend keeping it the same version so it will dedupe with npm's dependency of node-gyp.

If we really want newer node-gyp, in a more meaningful way, I have a branch over at atom-community/apm that bumps to npm 7, and here is a PR someone submitted to that repo to get ready for npm 8: atom-community/apm#123

confused-Techie · 2023-07-22T00:44:46Z

This PR is far to out of date to even be considered from merging.

But the efforts made within are still perfectly valid, and encouraged to be retake to anyone who has time. Eventually I myself would really like to take another shot at this, but doing so properly:

Do not decaf spec and source at the same time
Breaking up each item into singular PRs to properly and easily review
Have codacy configured properly to not ruin any chance at successful PR comments (This one is already done)

confused-Techie added 14 commits September 25, 2022 20:38

Properly fixing Windows Space in Path Issue

d00a398

Ran built in Build Scripts to generate JavaScript from CoffeeScript

a7e43fc

Rebranding in package generator templates

8af5417

Used built in utilities to decaffeinate tests

1cc7eee

Attempting to use naked Jasmine. Upgraded Express - Rewriting Express…

699a18b

… Middleware

Update ExpressJS Server

fe2aac5

Moved CoffeeScript specs to new folder for reference. Fixed scripts

2ccca90

Removed Coffee based dependencies

e5b4383

Fixed scripts

7bb0e5b

Updated node-gyp

4db21ca

Removed appveyor CI config, removed coffeelint config

ab1399e

Missed one item in archived CoffeeScript Specs

a8529a7

Missed another spec file

5802258

Added back in older Jasmine functions

a1b0647

codacy-production bot reviewed Oct 30, 2022

View reviewed changes

confused-Techie mentioned this pull request Nov 3, 2022

decaffeinate src/apm-cli.js + prepair file by file decaffeination #15

Closed

confused-Techie closed this Jul 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Various Revisions #8

Various Revisions #8

confused-Techie commented Sep 26, 2022 •

edited

Loading

codacy-production bot Oct 30, 2022

codacy-production bot Oct 30, 2022

codacy-production bot Oct 30, 2022

codacy-production bot Oct 30, 2022

codacy-production bot Oct 30, 2022

codacy-production bot Oct 30, 2022

codacy-production bot Oct 30, 2022

codacy-production bot Oct 30, 2022

codacy-production bot Oct 30, 2022

codacy-production bot Oct 30, 2022

codacy-production bot Oct 30, 2022

codacy-production bot Oct 30, 2022

codacy-production bot Oct 30, 2022

codacy-production bot Oct 30, 2022

codacy-production bot Oct 30, 2022

codacy-production bot Oct 30, 2022

codacy-production bot Oct 30, 2022

codacy-production bot Oct 30, 2022

DeeDeeG commented Nov 1, 2022

confused-Techie commented Jul 22, 2023

	describe('apm uninstall', function() {
	describe("apm uninstall", function () {

	atomReposHome = temp.mkdirSync('apm-repos-home-dir-');
	atomReposHome = temp.mkdirSync("apm-repos-home-dir-");

	currentDir = temp.mkdirSync('apm-init-');
	currentDir = temp.mkdirSync("apm-init-");

	return npm.load(npmOptions, function() {
	return npm.load(npmOptions, function () {

	describe('enabling and disabling packages', function() {
	describe("enabling and disabling packages", function () {

	app.get('/node/v10.20.1/node-v10.20.1-headers.tar.gz', function(request, response) {
	app.get(

	server.listen(3000, '127.0.0.1', function() {
	server.listen(3000, "127.0.0.1", function () {

	Link.prototype.run = function(options) {
	Link.prototype.run = function (options) {

	metadata = JSON.parse(fs.readFileSync(path.join(packageDirectory, 'package.json')));
	metadata = JSON.parse(

	this.devPackagesDirectory = path.join(config.getAtomDirectory(), 'dev', 'packages');
	this.devPackagesDirectory = path.join(

	child_process = require('child_process');
	child_process = require("child_process");


		_ = require('underscore-plus');

		plist = require('@atom/plist');

	plist = require('@atom/plist');
	plist = require("@atom/plist");

	replaceRegex = new RegExp("\\{\\{" + key + "\\}\\}", 'g');
	replaceRegex = new RegExp("\\{\\{" + key + "\\}\\}", "g");

	expect(console.log.argsForCall[0][0]).toMatch(/Not Disabled:\s*not-installed/);
	expect(console.log.argsForCall[0][0]).toMatch(

		@@ -0,0 +1,311 @@
		// Generated by CoffeeScript 1.12.7
		(function() {

	_ = require('underscore-plus');
	_ = require("underscore-plus");

		@@ -0,0 +1,127 @@
		// Generated by CoffeeScript 1.12.7
		(function() {

Various Revisions #8

Various Revisions #8

Conversation

confused-Techie commented Sep 26, 2022 • edited Loading

codacy-production bot Oct 30, 2022

Choose a reason for hiding this comment

codacy-production bot Oct 30, 2022

Choose a reason for hiding this comment

codacy-production bot Oct 30, 2022

Choose a reason for hiding this comment

codacy-production bot Oct 30, 2022

Choose a reason for hiding this comment

codacy-production bot Oct 30, 2022

Choose a reason for hiding this comment

codacy-production bot Oct 30, 2022

Choose a reason for hiding this comment

codacy-production bot Oct 30, 2022

Choose a reason for hiding this comment

codacy-production bot Oct 30, 2022

Choose a reason for hiding this comment

codacy-production bot Oct 30, 2022

Choose a reason for hiding this comment

codacy-production bot Oct 30, 2022

Choose a reason for hiding this comment

codacy-production bot Oct 30, 2022

Choose a reason for hiding this comment

codacy-production bot Oct 30, 2022

Choose a reason for hiding this comment

codacy-production bot Oct 30, 2022

Choose a reason for hiding this comment

codacy-production bot Oct 30, 2022

Choose a reason for hiding this comment

codacy-production bot Oct 30, 2022

Choose a reason for hiding this comment

codacy-production bot Oct 30, 2022

Choose a reason for hiding this comment

codacy-production bot Oct 30, 2022

Choose a reason for hiding this comment

codacy-production bot Oct 30, 2022

Choose a reason for hiding this comment

DeeDeeG commented Nov 1, 2022

confused-Techie commented Jul 22, 2023

confused-Techie commented Sep 26, 2022 •

edited

Loading