Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reading error of length property on null #1058

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

Digitalone1
Copy link
Contributor

Identify the Bug

Related to #876 (comment)

Description of the Change

Just check if matches is not a falsy js value where the read error occurs.

Alternate Designs

None.

Possible Drawbacks

None since it's good to check if the argument is not falsy when you have to read its properties.

Release Notes

In the same file there's the following comment (which I pasted above the changes):

// The findWordsWithSubsequence method will return `null`
// if the async work was cancelled due to the buffer being
// mutated since it was enqueued.

So the function in then may get null and that causes the issue. I hope this solves the syntax error explained in the link above.

Copy link
Member

@DeeDeeG DeeDeeG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late response.

Looks good to me!

If no objections raised we should be able to include this in Pulsar 1.122. Thank you once again for this contribution.

@DeeDeeG DeeDeeG merged commit 1ef8b8e into pulsar-edit:master Oct 15, 2024
103 of 104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants