Fix reading error of length property on null #1058
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug
Related to #876 (comment)
Description of the Change
Just check if
matches
is not a falsy js value where the read error occurs.Alternate Designs
None.
Possible Drawbacks
None since it's good to check if the argument is not falsy when you have to read its properties.
Release Notes
In the same file there's the following comment (which I pasted above the changes):
So the function in
then
may getnull
and that causes the issue. I hope this solves the syntax error explained in the link above.