Revert removal of shell.moveItemToTrash…
#1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…since it doesn’t work in Electron 12 on Windows. (Seems to work fine in Electron 30, so we'll just wait until the upgrade to migrate this usage.)
5 tasks
5 tasks
savetheclocktower
merged commit 6e2674c
into
pulsar-edit:master
102 of 103 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…since it doesn’t work in Electron 12 on Windows.
This reverts #1109 and should restore the status quo ante. I'd appreciate a review from a Windows user just to make certain; but if the tests pass, this should be safe to land.
The new method (
shell.trashItem) seems to work fine in PulsarNext, even on Windows. So instead of backporting this fix we'll just wait and fix it when we upgrade. (This was my first backport; how predictable that it'd backfire like this!)