test build with updated github for apple silicon #124
Conversation
benonymus
force-pushed
the
updated-github-test-build
branch
from
0ab4c7e to
7796736
Compare
benonymus
force-pushed
the
updated-github-test-build
branch
from
05ccabc to
29140dc
Compare
benonymus
force-pushed
the
updated-github-test-build
branch
from
29140dc to
c6fce33
Compare
| } | ||
| } | ||
| extraMetadata: {}, | ||
| asarUnpack: ["node_modules/github/bin/*"], |
There was a problem hiding this comment.
The extraMetadata is overwritten in the main function so this has no effect
There was a problem hiding this comment.
extraMetadata was here before, we could remove it then.
I only added asarUnpack.
There was a problem hiding this comment.
🤦 I thought asarUnpack was inside extraMetadata. Sorry for that.
There was a problem hiding this comment.
With the GitHub fixes, do we actually need this asarUnpack key?
|
Yes we do. The GitHub fixes are for apple silicon support.
Bence Janos Toth
________________________________
From: Maurício Szabo ***@***.***>
Sent: Saturday, November 12, 2022 11:13:06 PM
To: pulsar-edit/pulsar ***@***.***>
Cc: Bence Janos Toth ***@***.***>; Author ***@***.***>
Subject: Re: [pulsar-edit/pulsar] test build with updated github for apple silicon (PR #124)
@mauricioszabo commented on this pull request.
________________________________
In script/electron-builder.js<#124 (comment)>:
},
- "extraMetadata": {
- }
-}
+ extraMetadata: {},
+ asarUnpack: ["node_modules/github/bin/*"],
With the GitHub fixes, do we actually need this asarUnpack key?
—
Reply to this email directly, view it on GitHub<#124 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADMN6Q7ECIVOPVF2EIWZQ3LWH66ZFANCNFSM6AAAAAAR3Q5UJA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
@benonymus, you should open a new PR for |
Yeah that is fair. If we say this this is fine by others as well. This additional issue was only discovered after I made the fix for Apple Silicon. It fixes this: https://discord.com/channels/992103415163396136/992103415163396139/1040564640062648370 Here is the pr: #140 |
|
Technically this pr can be closed. I got what I wanted to try. What do you think @mauricioszabo ? |
|
Like stated above that this should be closed, now especially as we have #186 merged, should we close this one @benonymus? |
I want to test out the updated github library on a real build, to verify the fix.