Skip to content

Conversation

@savetheclocktower
Copy link
Contributor

This is a draft for now but is being opened ahead of time so that I don't forget to do it later — or, worse, let these changes sit unstaged in my Pulsar project folder until I forget ever having written them.

When we ship a terminal, the colors it uses should be harmonious with those of the user's own syntax theme. The best way to do that is to have the theme be in charge of the colors used. On a superficial level, this is easy: base the terminal's foreground color on the theme's editor text color, and its background color on the theme's editor background color.

The ANSI colors, however, are where the rubber meets the road. For most themes, we can just fall back to some default color values that look decent enough in both light and dark themes. But there's no reason not to define the correct variables for all eight of our bundled syntax themes! That's what this PR does.

It also updates the fallback syntax-variables.less that's present as a failsafe if your syntax theme is very rude and noncompliant and doesn't define even the most basic of syntax variables itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants