Fix autocomplete-plus crash with non-workspace editors #1381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
You've opened this against Can you check out a new branch from |
The subsequence-provider crashes when autocomplete is triggered in editors that are not part of the workspace (e.g., watch pane editors in hydrogen-next). This happens because the editor buffer is not tracked in watchedBuffers. Changes: - Add guard in bufferToSubsequenceMatches to return empty results for untracked buffers instead of crashing - Filter buffers in getSuggestions to only include those in watchedBuffers - Add null check in subsequenceMatchToType for safety Fixes crashes when using autocomplete.watchEditor API with non-workspace editors. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
asiloisad
force-pushed
the
fix/autocomplete-non-workspace-editors
branch
from
17eeedb to
09c9fda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The
subsequence-providercrashes withCannot read properties of undefined (reading 'getCursorBufferPosition')when autocomplete is triggered in editors created viaatom.workspace.buildTextEditor()that are not part of the workspace.This happens because:
watchEditor()API registers the editor for autocompletesubsequence-provider.getSuggestions()tries to get completions from the editor bufferwatchedBuffersmap (only workspace editors are tracked)this.watchedBuffers.get(buffer)returnsundefined.getCursorBufferPosition()onundefinedcrashesSolution
bufferToSubsequenceMatchesto return empty results for untracked buffersgetSuggestionsto only include those inwatchedBufferssubsequenceMatchToTypefor safetyTest plan
#1224