-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More Bundles #290
Merged
Merged
More Bundles #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sertonix
suggested changes
Jan 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add/update packages/*/package-lock.json
s?
And maybe remove the standart linter.
@sertonix done and done |
sertonix
approved these changes
Jan 3, 2023
Since it's approved, gonna go ahead and merge this one to help reduce the diff on #293 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing new in this PR, I've tried to follow all previous best practices while continuing the bundling of additional Core packages.
Many of the packages chosen for this bundle either have failing tests I'd like to focus on fixing up, or would've needed version bumps here to receive updates that have happened in their individual repositories. Which this PR accomplishes.
Additional rebranding work is likely available in these new bundles as was done in their original repos.
The new Bundled Packages:
If nobody has any issues with the way they are bundled we should be good to go ahead and merge.