Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Bundles #290

Merged
merged 9 commits into from
Jan 3, 2023
Merged

More Bundles #290

merged 9 commits into from
Jan 3, 2023

Conversation

confused-Techie
Copy link
Member

Nothing new in this PR, I've tried to follow all previous best practices while continuing the bundling of additional Core packages.

Many of the packages chosen for this bundle either have failing tests I'd like to focus on fixing up, or would've needed version bumps here to receive updates that have happened in their individual repositories. Which this PR accomplishes.

Additional rebranding work is likely available in these new bundles as was done in their original repos.

The new Bundled Packages:

  • bookmarks
  • archive-view
  • image-view
  • background-tips

If nobody has any issues with the way they are bundled we should be good to go ahead and merge.

Copy link
Contributor

@sertonix sertonix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add/update packages/*/package-lock.jsons?
And maybe remove the standart linter.

@confused-Techie
Copy link
Member Author

@sertonix done and done

@confused-Techie
Copy link
Member Author

Since it's approved, gonna go ahead and merge this one to help reduce the diff on #293

@confused-Techie confused-Techie merged commit d2c4be2 into master Jan 3, 2023
@Spiker985 Spiker985 deleted the finish-bundling branch February 24, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants