meta: Delete preinstall script from package.json #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This script launches Node to run a script that has it immediately exit ... It is from way back in 2012, when Atom still had a binding.gyp at the root dir of the project. See commit 2697b5e's commit message for details of why this was added, then see commit 010905d, and see also npm's "scripts" documentation page: > If there is a binding.gyp file in the root of your package > and you haven't defined your own install or preinstall scripts, > npm will default the install command to compile using node-gyp > via node-gyp rebuild - Source: https://docs.npmjs.com/cli/v9/using-npm/scripts#npm-install ... But there's no binding.gyp in the project root anymore, hasn't been for a while, and keeping this script all these years has been fairly silly, and wastes a few seconds of time and some tiny amount of RAM/ disk access, I suppose. It does not spark joy, so I am saying goodbye to this script. "Goodbye, preinstall script."
|
Easy merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This script launches Node to run a script that has it immediately exit ... It is from way back in 2012, when Atom still had a binding.gyp at the root dir of the project.
See commit 2697b5e's commit message for details of why this was added, then see commit 010905d, and see also npm's "scripts" documentation page:
...
But there's no binding.gyp in the project root anymore, hasn't been for a while, and keeping this script all these years has been fairly silly, and wastes a few seconds of time and some tiny amount of RAM/ disk access, I suppose.
It does not spark joy, so I am saying goodbye to this script.
"Goodbye, preinstall script."