Resolve all Tests within language-javascript
(Resolves 24 Failing Tests)
#299
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like we had 24 failing tests within
language-javascript
because of our Pulsar version.Essentially there was a check here that if the version of the editor was below
1.21
it would revert to an old style ofscopeSelector
but above that version would use the newer style.Since we have now moved to Pulsar
1.100.0
when1.100.0-dev <= 1.21
was evaluated it would returntrue
and use the old style.So this PR simply removes the if else block handling this (As we shouldn't be worried about supporting versions of Pulsar lower than this because they don't exist.) and statically assigns these
scopeSelectors
with the newer style. Which still using them will at least let us change them more easily in the future if we ever need to.Additionally this PR removes the comment saying to remove the if else block after Atom
1.21
was released.And in local testing this now resolves all failing
language-javascript
tests, which account for 24 of the failing test on this package test bundle. The bundle likely won't be totally passing yet, as I believe there are still a handful more that fail in that bundle.