Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve all Tests within language-javascript (Resolves 24 Failing Tests) #299

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

confused-Techie
Copy link
Member

Looks like we had 24 failing tests within language-javascript because of our Pulsar version.

Essentially there was a check here that if the version of the editor was below 1.21 it would revert to an old style of scopeSelector but above that version would use the newer style.

Since we have now moved to Pulsar 1.100.0 when 1.100.0-dev <= 1.21 was evaluated it would return true and use the old style.

So this PR simply removes the if else block handling this (As we shouldn't be worried about supporting versions of Pulsar lower than this because they don't exist.) and statically assigns these scopeSelectors with the newer style. Which still using them will at least let us change them more easily in the future if we ever need to.

Additionally this PR removes the comment saying to remove the if else block after Atom 1.21 was released.

And in local testing this now resolves all failing language-javascript tests, which account for 24 of the failing test on this package test bundle. The bundle likely won't be totally passing yet, as I believe there are still a handful more that fail in that bundle.

@confused-Techie confused-Techie merged commit 135381b into master Jan 5, 2023
@icecream17 icecream17 mentioned this pull request Jan 10, 2023
3 tasks
@Spiker985 Spiker985 deleted the javascript-tests branch February 24, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants