-
-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle markdown-preview
, styleguide
, wrap-guide
#374
Conversation
symbols-view
, markdown-preview
, styleguide
, wrap-guide
Just adding that the |
So a quick peek at how the tests are looking here:
So while mostly everything looks fine, we are getting far more failures on I'll go ahead and look into this, but until then this shouldn't be merged. |
So something interesting, I've confirmed the files I brought over for Almost makes me wonder if these aren't failing because of something else? As really the installing process shouldn't be any different now than it was with the previous |
Alright, I've tried to replicate the test results we have received otherwise to our previous expected fail rate, but can't seem to get it right. After much testing locally I wasn't able to determine what the difference is between these repos when bundled or installed from GitHub. Going as far as to check file diffs from For the time being I've opted to instead remove |
symbols-view
, markdown-preview
, styleguide
, wrap-guide
symbols-view
~~, markdown-preview
, styleguide
, wrap-guide
symbols-view
~~, markdown-preview
, styleguide
, wrap-guide
symbols-view
~, markdown-preview
, styleguide
, wrap-guide
symbols-view
~, markdown-preview
, styleguide
, wrap-guide
markdown-preview
, styleguide
, wrap-guide
To add the test results now that everythings come back:
Additionally the intel mac build is failing in the same way seen on other PRs. Leads me to believe something has changed on cirrus' end rather than ours. But still noteworthy |
@pulsar-edit/core if anyone's willing to take a look at this that'd be rad. Otherwise as it's technically a non-code change we can go ahead and merge it. All it does is move the code from a repo to our |
@confused-Techie do you mind if this is rebased on latest A bit paranoid, but IMO it'd still be nice to be reassured the intel Mac Cirrus job works fine with the "pin Python to 3.10" fix from #384. EDIT: I volunteer to do the rebase (or merge |
@DeeDeeG you are totally free to do it, if you've got the workflow up. Otherwise I'll also go ahead and try to do it sometime tonight. Thanks for taking a look |
aaf2908
to
f63a89f
Compare
Alright @DeeDeeG thanks for merging our changes the other day, but with #399 being merged, we had to do this yet again. So I've done so and taking a look at the tests everything, almost looks perfect. The package tests are all within expected range:
Although the Cirrus CI But I've gone ahead and requested a rerun, so hopefully we can finally review and merge this one, once those are done if things look good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI looks good now!
Thanks for waiting on those runs/re-running, etc.
This PR does nothing new or fancy.
Just continuing (yet again) the process of bundling and testing our core packages.
This PR bundles the following packages:
symbols-view
(Note this PR no longer bundlessymbols-view
read below for details)markdown-preview
styleguide
wrap-guide
Hopefully after this we will only need one last major bundling PR to grab the vast majority of the others.
Than from there we still will have a few others to bundle that have active and open PRs or issues.