Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using "second-mate" #435

Merged
merged 14 commits into from
Mar 29, 2023
Merged

Using "second-mate" #435

merged 14 commits into from
Mar 29, 2023

Conversation

mauricioszabo
Copy link
Contributor

Second-mate is basically the Atom's "First Mate" (TextMate helpers) but converted to use vscode-oniguruma instead of node-oniguruma.

This PR adds support for second-mate as the TextMate tokenizer. For related PRs, see here: pulsar-edit/second-mate#1

We may need more tests on this code, and also fix bracket-matcher (that it needs first-mate - maybe even use Pulsar's tokenizer instead)

@confused-Techie
Copy link
Member

Excited to see how the tests turns out on this one

@savetheclocktower
Copy link
Contributor

I should've mentioned this on the second-mate repo, but: if we can replicate the OnigRegExp API with only OnigScanner, it'd be great if we could do that in second-mate and export both OnigRegExp and OnigScanner from second-mate itself — just to prevent having to rewrite all these usages.

@mauricioszabo
Copy link
Contributor Author

@savetheclocktower yeah, that's a good idea...

Unfortunate, it's too late now 😆

@mauricioszabo
Copy link
Contributor Author

I honestly didn't like the errors the CI reported...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants