-
-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using "second-mate" #435
Using "second-mate" #435
Conversation
Excited to see how the tests turns out on this one |
I should've mentioned this on the |
@savetheclocktower yeah, that's a good idea... Unfortunate, it's too late now 😆 |
I honestly didn't like the errors the CI reported... |
Second-mate is basically the Atom's "First Mate" (TextMate helpers) but converted to use
vscode-oniguruma
instead ofnode-oniguruma
.This PR adds support for second-mate as the TextMate tokenizer. For related PRs, see here: pulsar-edit/second-mate#1
We may need more tests on this code, and also fix bracket-matcher (that it needs first-mate - maybe even use Pulsar's tokenizer instead)