Removed "ghost" submodule #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
confused-Techie
approved these changes
Sep 7, 2022
There was a problem hiding this comment.
See no reason we shouldn't merge this, its strange its here at all.
Only slight concern is that all Mac builds failed to install. But those fail on and off anyways, and I can't imagine they secretly depend on this ghost submodule, so don't think its significant.
Otherwise totally approve commiting this.
|
Alright this has been up for a bit, with no issues raised against it. Should we go ahead and merge? Tests look good and seems almost like a no brainer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.