[dalek] Bump dependencies to latest, fix links #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to be sure, the change to engine would mean that next release this wouldn't work, correct? Just making sure that is the intended change |
|
@Spiker985 Good catch there. That was not the intended change. Must have mistakenly saw the short value of the semver and assumed it was already out of date with the version we were currently using. I've changes that one back, thanks for seeing it |
|
No problem! Otherwise, barring testing issues, should be good 👍 |
Spiker985
approved these changes
Jun 23, 2023
|
@Spiker985 I appreciate the review! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Low hanging fruit PR, bumped our dependencies in
dalekas well as fixing a link in the deprecation notice, that still linked to Atom's repo. Nothing to crazy, ensured tests ran just fine, and compared the diffs between these new versions to ensure there were no to crazy API changes.Additionally updated the
engines.atomversion to point to our latest release.