Small fixes on build #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
confused-Techie
approved these changes
Sep 20, 2022
There was a problem hiding this comment.
Totally approve the improvements here. Especially seeing that both Mac and Linux builds are fine, and tests are right where we expect them (not that this should really change the tests in any meaningful way)
Otherwise wanted to point out that the Windows Cirrus Scripts are trying to cd apm should this be updated to ppm for them to work? Or am I behind the times on that one?
Otherwise lets get this merged
|
Ok, @confused-Techie, let's merge this and concentrate on Windows next 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just 2 small changes:
appIdrm distanymore for the build scripts