Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump .nvmrc to 16 #71

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Conversation

Daeraxa
Copy link
Member

@Daeraxa Daeraxa commented Sep 26, 2022

Bumping to default to 16 (not specified an exact version, can change to lts/* if people prefer or a specific 16.x.x version).

The current version in here doesn't even work (node 12) so we lose nothing by bumping to at least 14 and stops install failing when using deeper nvm integration.

Copy link
Contributor

@mauricioszabo mauricioszabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's little difference in bumping versions because most packages are compiled via electron-rebuilder, but I see no problems on bumping this :)

@Daeraxa
Copy link
Member Author

Daeraxa commented Sep 26, 2022

Its mostly just helpful for those using deeper nvm integration.
If I change to a directory with the older .nvmrc then it automatically uses node 12 which then fails on yarn install. This way you can just nvm use in the root of the project and it will always go to whatever latest node 16 you have (or tell you to install it).

Also potentially means I can update the build docs to say just run nvm install instead of nvm install 16 so it just automatically tracks whatever the recommended version of node is for the project (so long as this file is kept updated).

Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. And love getting our docs simpler for everyone.

With an additional approval, I'll approve here and merge.

@confused-Techie confused-Techie merged commit 7d8a883 into pulsar-edit:master Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants