First pass at an atom.signal API (inter-window communcation)
#826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savetheclocktower
changed the title
atom.signal API.atom.signal API (inter-window communcation)
Whenever `pulsar-updater` shows a notification in any window, it will send a signal to all other windows when that notification is dismissed. The other windows can dismiss any of their `pulsar-updater` notifications. This allows the user to dismiss _one_ notification instead of one per window.
savetheclocktower
force-pushed
the
signals-part-2
branch
from
70943df
to
839d4b3
Compare
|
Updated this just now with a proof-of-concept in This will stay in draft until I write some tests, but I wanted to update it while it was fresh on my mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #822.
Description of the Change
Implements a simplified API for one window to send a signal to all windows, optionally including itself. (#822 explores scenarios where this could be needed.) We use the main process to act as a broker.
Alternate Designs
I started out envisioning that this would combine reactivity and storage, much like
atom.config. But we can already uselocalStoragefor the storage side, and I didn’t feel like reimplementing the whole thing when what’s most urgently needed is the signaling.Possible Drawbacks
I can’t really think of any. This is a pretty thin layer over Electron’s built-in tools for communicating between the main process and the individual renderer processes.
Verification Process
None yet! This PR is in draft mode while I figure out exactly how I’m gonna test this thing.
Release Notes
atom.signal, an API for sending messages between different Pulsar windows.