[find-and-replace] Fix capitalize utility

[savetheclocktower]

Fixes discussions/244.

Identify the Bug

A utility function in the find-and-replace package for capitalizing strings was doomed to fail when given an empty string as input. It assumed it could call toUpperCase on the string’s first character.

Nobody noticed this because it doesn’t happen unless the user enables the Preserve Case During Replace option (which is false by default).

Description of the Change

Return empty strings as-is, for there is nothing to capitalize.

I also took this opportunity to rename the setting from Preserve case during replace. to Preserve Case During Replace. I don’t love How We Title-Case Every Single Setting, but if we’re going to do it, we should be consistent about it.

Alternate Designs

I really didn’t think too hard about this one.

Possible Drawbacks

We provide such a smooth and bug-free experience that Pulsar users take us completely for granted.

Verification Process

• Open a new file. Type a word on each of the first three lines.
• Open the Find and Replace dialog and enable the regex option. Find ^ and replace with ;. Click on Find All, then on Replace All.
• This action should fail on master and pass on this PR branch.

Release Notes

Fix certain find-and-replace scenarios when the “Preserve Case During Replace” setting is enabled.

[confused-Techie]

Easy approve from me here! Glad to see all tests passing, and that the setting key hasn't been touched when changing it's case (not that it actually needed to be).

So lets get this merged! Love a quick bug fix