[meta] Update Cirrus GITHUB_TOKEN

[confused-Techie]

This PR updates the GITHUB_TOKEN for CirrusCI.
As the previously used token had expired yesterday.

Getting this updated will be a requirement for our next Regular Release

[meadowsys]

looks good to me!

edit: I don't think we need to wait for CI here, right? heh

[DeeDeeG]

Also approving this.

The only way we'd know if this is not working is if we mange to get rate-limited in the vscode-ripgrep download in Cirrus. Hard to prove the opposite (that it is authed to the github.com REST API properly) with just one CI run anyhow.

[meadowsys]

The only way we'd know if this is not working

now I wonder if the GitHub API just silently proceeds unauthenticated (if it can) on invalid token, or hard errors (I would think its the latter, but I'm not sure, thinking about it)

[confused-Techie]

@meadowsys From my experience GitHub will error out on an invalid token. Since at that point it becomes an authentication failure, rather than a missing parameter it will try to skip. So pretty sure if we incorrectly set this value we would see lots of failures on the next CirrusCI run due to authentication failures in GitHub.

But thanks both of your for your review!

[meadowsys]

GitHub will error out on an invalid token

then it would be pretty obvious if it doesn't work, will just error out immediately >w<