Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Update github to v0.36.20-pretranspiled to bump dugite #925

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

DeeDeeG
Copy link
Member

@DeeDeeG DeeDeeG commented Feb 15, 2024

Includes github PR:

(Which I excluded at the last moment from the previous github package version, v0.36.19[-pretranspiled].)
...
Effectively bumps dugite from 2.1.0 to 2.5.2.
Should improve github package's compatibility with ARM Linux?

Description of the Change

Update github to v0.36.20-pretranspiled to bump dugite.

Effectively bumps dugite from 2.1.0 to 2.5.2.
Should improve github package's compatibility with ARM Linux?

Alternate Designs

Don't bump dugite?

Possible Drawbacks

Not super widely tested, but with some brief testing, this didn't surface any issues last time a couple of people looked at it (myself and Dae at least).

Verification Process

I tested this bump not breaking anything on my x86-64 machine some weeks ago, and at that time I believe @Daeraxa was also able to confirm it made the github package less broken on ARM Linux at that time.

EDIT: Tested this some more just now on macOS, with this PR's binary, looking good to me.

Release Notes

Update github package to v0.36.20-pretranspiled, to bump dugite dependency to 2.5.2 -- should improve github package's compatibility with ARM Linux

Effectively bumps dugite from 2.1.0 to 2.5.2.
Should improve github package's compatibility with ARM Linux?
Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The manual testing and tests passing here gives lots of confidence.

Do we wanna get this in for this release?

@DeeDeeG
Copy link
Member Author

DeeDeeG commented Feb 16, 2024

Did a bunch of stuff in the git and github panes, everything I tried appears to work.

  • git pane
    • initializing a new git repo
    • Creating new branches
    • Staging and unstaging hunks, files, lines via the UI
    • Committing changes
    • Switching between branches
  • github pane
    • Logging into github pane
      • Detection of incorrect scopes works and logs properly to the dev tools console, btw. Probably off-topic to this PR though.
    • Clicking around to view open PRs for the repo works

@DeeDeeG
Copy link
Member Author

DeeDeeG commented Feb 16, 2024

Thank you for the approve, and with some further last minute testing, I think we are good to go merging this for 1.114 today.

Merging now!

@DeeDeeG DeeDeeG merged commit b931457 into master Feb 16, 2024
103 checks passed
@DeeDeeG DeeDeeG deleted the update-github-v0.36.20-pretranspiled-bump-dugite branch April 19, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants