[symbols-view] Remap go-to-declaration commands on Windows/Linux #926
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick one. @Spiker985 discovered that the Symbols View: Go To Declaration and Symbols View: Return From Declaration commands used key shortcuts that shadowed the built-in Editor: Add Selection Above and Editor: Add Selection Below commands on Windows and Linux.
The
symbols-view
commands didn't even have mapped keys on Windows until 1.113. (If I had to guess, I'd guess thatctags
didn't work on Windows at some point?) But these commands have always conflicted with one another on Linux!To fix this, I'm adding a modifier key to the default key combinations on these two platforms. These new key combinations don't conflict with anything in the core
keymaps
folder, nor any other keymaps I can find in thepulsar
project.