Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[symbols-view] Remap go-to-declaration commands on Windows/Linux #926

Merged

Conversation

savetheclocktower
Copy link
Contributor

This is a quick one. @Spiker985 discovered that the Symbols View: Go To Declaration and Symbols View: Return From Declaration commands used key shortcuts that shadowed the built-in Editor: Add Selection Above and Editor: Add Selection Below commands on Windows and Linux.

The symbols-view commands didn't even have mapped keys on Windows until 1.113. (If I had to guess, I'd guess that ctags didn't work on Windows at some point?) But these commands have always conflicted with one another on Linux!

To fix this, I'm adding a modifier key to the default key combinations on these two platforms. These new key combinations don't conflict with anything in the core keymaps folder, nor any other keymaps I can find in the pulsar project.

Copy link
Member

@DeeDeeG DeeDeeG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this just now. I'm pretty sure this is a desirable outcome from the tests?

On Windows:

  • Pulsar 1.113.0 (without this PR)
    • Ctrl + Alt + Down flips my display output upside-down ❌
    • Ctrl + Shift + Alt + Down does nothing ❌
  • Pulsar bins from this PR (Pulsar "1.113.2024021522")
    • Ctrl + Alt + Down still flips my display output upside-down ❌
    • Ctrl + Shift + Alt + Down goes to the definition of the thing my cursor is on ✅ <-- this is what we want

Tested with https://web.pulsar-edit.dev/packages/pulsar-ide-clangd and clangd in a .c file.

@DeeDeeG
Copy link
Member

DeeDeeG commented Feb 16, 2024

Merging now, thanks!

@DeeDeeG DeeDeeG merged commit f767672 into pulsar-edit:master Feb 16, 2024
103 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants