Fix(fuzzy-finder) fs.lstatSync throws Exception if not a file or dir

[schadomi7]

Identify the Bug

While trying to fix a self-hosted teletype version, I noticed the fuzzy-finder is broken with teletype and it is because of this:

If you try to use the fuzzy-finder while connected via teletype, it fails with an exception.
This is caused by a check if the uri is a directory. The used fs.lstatSync will throw if given path is not found.
Previously it used a fs-plus method, which did not throw.
Because it throws, the else branch is never reached for the teletype URIs.

Description of the Change

wrap fs.lstatSync in a try-catch block

Alternate Designs

I would love to do something like this

    } else if (fs.lstatSync(uri, {throwIfNoEntry: false})?.isDirectory()) {

unfortunately throwIfNoEntry is only available in newer versions of fs.

Alternative 2: Could revert to fs-plus, the old code did not throw
Alternative 3: It could be sufficient to explicitly check if it is a teletype URI, I do not know if there could be other types of URI.
Teletype URIs all start with atom://teletype/

Possible Drawbacks

Code could be harder to read.

Verification Process

I used the fuzzy-finder, did not crash. Also did not crash with teletype.

Release Notes

N/A

[confused-Techie]

Sorry this took some time to check up on.

But thanks a ton for contributing! This code honestly looks fantastic for me, and thanks for clarifying the use of throwIfNoEntry since that'd be my knee jerk reaction here.

Otherwise this looks good to me, and seems like it should be good to merge with all tests passing.

Anyone else have any input? Or think we are good to land this in time for v1.115.0?

[DeeDeeG]

If I recall correctly, fs-plus is using try/catch under the hood in these situations anyway.

So, this instance of just manually re-adding the try/catch seems fine to me as well.

Thanks from me also for the contribution!

[confused-Techie]

@DeeDeeG You are 100% correct, under the hood it's just a try...catch

https://github.com/atom/fs-plus/blob/ba56f01d4f434982dff734186b3b6522eb28de75/src/fs-plus.mjs#L722