-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for 'stack output' command (reopened) #1002
Conversation
Support for 'pulumi stack outputs' command
…pulumi-actions into feature/outputs-support
…pulumi-actions into feature/outputs-support
@RobbieMcKinstry please verify it on your side, since there have been multiple changes in the project in the meantime. |
Hi @mikocot , I'm afraid I'm no longer a maintainer on this repository. I'll refer you to @justinvp or @simenandre who are able to review your pull request. As a fellow community member, thank you for your contribution, and your patience. I apologize for having lost track of your PR when I was a maintainer. It was an oversight. |
This looks reasonable to me. @simenandre any comments before we merge? My only thought is maybe this should have a test for it, but I'm not up to speed with how we're doing testing in this repo, so I'll defer that to you. |
@simenandre any comments? :) |
Looks like something needs an update here, CI is complaining about:
|
I think |
to be honest it might have got out of date in the meantime 🙄 |
I fixed the previous conflict on the changelog, but now there is a new one. Can we please move on with this? @Frassle ? |
There we go :) Was a couple of minor things to fix up but merged now. |
great, we'll test it as soon as it's out, thanks |
This PR introduced support for
pulumi stack output
command in addition to the existing ones.The reasons for this change are explained in the following issue:
#868
I've chosen
output
as a name for the command as it reflects the method called by CLI, although internally in the sdk it callsstack.outputs()
.As mentioned previously I have issues testing this solution, so I invite you to test it yourself and collaborate on the final solution. I have found no relevant tests nor I can see a good way to unit test it, but I've updated the test workflow.
__
Reopened due to GH not recognizing the changes correctly in the original one after rebase.